Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3487)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.h

Issue 2888673002: Add support for counting same-document AMP loads. (Closed)
Patch Set: address comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.h b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
index 3e12c65c34b10841368efbd8e0601ef831b2c182..52728cdc90011ae13b26e0208c58d9645b135c19 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
@@ -304,8 +304,15 @@ class PageLoadMetricsObserver {
// observer to query |navigation_handle| to determine which happened. Note
// that |navigation_handle| will be destroyed soon after this call. Don't
// hold a reference to it.
- virtual ObservePolicy OnDidFinishSubFrameNavigation(
- content::NavigationHandle* navigation_handle);
+ virtual void OnDidFinishSubFrameNavigation(
+ content::NavigationHandle* navigation_handle) {}
+
+ // OnCommitSameDocumentNavigation is triggered when a same-document navigation
+ // commits within the main frame of the current page. Note that
+ // |navigation_handle| will be destroyed soon after this call. Don't hold a
+ // reference to it.
+ virtual void OnCommitSameDocumentNavigation(
+ content::NavigationHandle* navigation_handle) {}
// OnHidden is triggered when a page leaves the foreground. It does not fire
// when a foreground page is permanently closed; for that, listen to

Powered by Google App Engine
This is Rietveld 408576698