Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h

Issue 2888673002: Add support for counting same-document AMP loads. (Closed)
Patch Set: address comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
index 5225b74c36330392bceb7d30ba5b39b4dec659af..2b4fb5249d5b5d79523040bb029b4793bb95a721 100644
--- a/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h
@@ -26,11 +26,17 @@ struct PageLoadTiming;
class AMPPageLoadMetricsObserver
: public page_load_metrics::PageLoadMetricsObserver {
public:
+ // If you add elements to this enum, make sure you update the enum value in
+ // enums.xml. Only add elements to the end to prevent inconsistencies between
+ // versions.
enum class AMPViewType {
NONE,
AMP_CACHE,
GOOGLE_SEARCH_AMP_VIEWER,
GOOGLE_NEWS_AMP_VIEWER,
+
+ // New values should be added before this final entry.
+ AMP_VIEW_TYPE_LAST
};
static AMPViewType GetAMPViewType(const GURL& url);
@@ -40,6 +46,8 @@ class AMPPageLoadMetricsObserver
// page_load_metrics::PageLoadMetricsObserver:
ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;
+ void OnCommitSameDocumentNavigation(
+ content::NavigationHandle* navigation_handle) override;
void OnDomContentLoadedEventStart(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
@@ -55,6 +63,7 @@ class AMPPageLoadMetricsObserver
const page_load_metrics::PageLoadExtraInfo& info) override;
private:
+ GURL current_url_;
AMPViewType view_type_ = AMPViewType::NONE;
DISALLOW_COPY_AND_ASSIGN(AMPPageLoadMetricsObserver);

Powered by Google App Engine
This is Rietveld 408576698