Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2888673002: Add support for counting same-document AMP loads. (Closed)
Patch Set: address comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
index 181c30de2d376a2d3e5ea9fcb644900d2fd0d1f9..2a51ccbdcf57f8ef79caa3ad2cc8f30c251e85d2 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
@@ -106,12 +106,6 @@ PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnCommit(
return CONTINUE_OBSERVING;
}
-PageLoadMetricsObserver::ObservePolicy
-PageLoadMetricsObserver::OnDidFinishSubFrameNavigation(
- content::NavigationHandle* navigation_handle) {
- return CONTINUE_OBSERVING;
-}
-
PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnHidden(
const PageLoadTiming& timing,
const PageLoadExtraInfo& extra_info) {
« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/page_load_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698