Remove raw base::DictionaryValue::SetWithoutPathExpansion

Remove raw base::DictionaryValue::SetWithoutPathExpansion

This change removes the deprecated raw pointer version of
base::DictionaryValue::SetWithoutPathExpansion and replaces it with the
unique pointer version or other convenience functions where appropriate.

BUG=646113, 581865
Review-Url: https://codereview.chromium.org/2884933002
Cr-Commit-Position: refs/heads/master@{#473525}
Committed: https://chromium.googlesource.com/chromium/src/+/89aa5721a06d876d9bcd20387a8c48794a208e7c

[jdoerrie, 2017-05-16 09:25:22]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 09:25:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 09:38:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 09:38:39]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[jdoerrie, 2017-05-16 14:11:14]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 14:12:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 14:24:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 14:24:09]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[jdoerrie, 2017-05-16 16:23:42]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 16:24:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 18:26:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 18:26:41]

Dry run: This issue passed the CQ dry run.

[jdoerrie, 2017-05-17 05:40:53]

Description was changed from

==========
Remove raw base::DictionaryValue::SetWithoutPathExpansion

BUG=646113, 581865
==========

to

==========
Remove raw base::DictionaryValue::SetWithoutPathExpansion

This change removes the deprecated raw pointer version of
base::DictionaryValue::SetWithoutPathExpansion and replaces it with the
unique pointer version or other convenience functions where appropriate.

BUG=646113, 581865
==========

[jdoerrie, 2017-05-17 05:40:54]

jdoerrie@chromium.org changed reviewers:
+ brettw@chromium.org, vabr@chromium.org

[jdoerrie, 2017-05-17 05:42:59]

vabr@chromium.org: Please review the whole CL in detail. 

brettw@chromium.org: Please spot-check and rubber-stamp.

[vabr (Chromium), 2017-05-17 11:00:05]

LGTM, very happy to see SetWithoutPathExpansion(raw) gone!
Cheers,
Vaclav

https://codereview.chromium.org/2884933002/diff/40001/tools/json_schema_compi...
File tools/json_schema_compiler/test/test_util.cc (right):

https://codereview.chromium.org/2884933002/diff/40001/tools/json_schema_compi...
tools/json_schema_compiler/test/test_util.cc:28: list->Append(std::move(a));
#include <utility> for std::move?

[jdoerrie, 2017-05-17 11:51:03]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 11:51:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-05-17 11:51:30]

Thanks, Vaclav!

https://codereview.chromium.org/2884933002/diff/40001/tools/json_schema_compi...
File tools/json_schema_compiler/test/test_util.cc (right):

https://codereview.chromium.org/2884933002/diff/40001/tools/json_schema_compi...
tools/json_schema_compiler/test/test_util.cc:28: list->Append(std::move(a));
On 2017/05/17 11:00:04, vabr (hobby-only until 5 June) wrote:
> #include <utility> for std::move?

Done.

[commit-bot: I haz the power, 2017-05-17 13:28:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 13:28:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2017-05-18 22:54:07]

lgtm

[jdoerrie, 2017-05-19 06:07:03]

The CQ bit was checked by jdoerrie@chromium.org

[jdoerrie, 2017-05-19 06:07:05]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2884933002/#ps60001
(title: "Include")

[commit-bot: I haz the power, 2017-05-19 06:07:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 06:16:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 06:16:21]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jdoerrie, 2017-05-19 07:14:39]

The CQ bit was checked by jdoerrie@chromium.org

[commit-bot: I haz the power, 2017-05-19 07:15:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 07:25:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 07:25:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jdoerrie, 2017-05-19 07:57:07]

jdoerrie@chromium.org changed reviewers:
+ stevenjb@chromium.org

[jdoerrie, 2017-05-19 07:57:07]

stevenjb@chromium.org: Please review changes in
chromeos/network/onc/onc_translator_shill_to_onc.cc

[stevenjb, 2017-05-19 16:42:19]

chromeos/ lgtm

[jdoerrie, 2017-05-22 06:44:09]

The CQ bit was checked by jdoerrie@chromium.org

[commit-bot: I haz the power, 2017-05-22 06:44:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 08:36:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495435449084860,
"parent_rev": "02593427f2c54e7bcbc93def5b27268a85d6d451", "commit_rev":
"89aa5721a06d876d9bcd20387a8c48794a208e7c"}

[commit-bot: I haz the power, 2017-05-22 08:36:21]

Description was changed from

==========
Remove raw base::DictionaryValue::SetWithoutPathExpansion

This change removes the deprecated raw pointer version of
base::DictionaryValue::SetWithoutPathExpansion and replaces it with the
unique pointer version or other convenience functions where appropriate.

BUG=646113, 581865
==========

to

==========
Remove raw base::DictionaryValue::SetWithoutPathExpansion

This change removes the deprecated raw pointer version of
base::DictionaryValue::SetWithoutPathExpansion and replaces it with the
unique pointer version or other convenience functions where appropriate.

BUG=646113, 581865

Review-Url: https://codereview.chromium.org/2884933002
Cr-Commit-Position: refs/heads/master@{#473525}
Committed:
https://chromium.googlesource.com/chromium/src/+/89aa5721a06d876d9bcd20387a8c...
==========

[commit-bot: I haz the power, 2017-05-22 08:36:22]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/89aa5721a06d876d9bcd20387a8c...