Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1598)

Unified Diff: extensions/browser/api/bluetooth_low_energy/utils.cc

Issue 2884933002: Remove raw base::DictionaryValue::SetWithoutPathExpansion (Closed)
Patch Set: Include Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/values_util_unittest.cc ('k') | ios/chrome/browser/autofill/autofill_agent.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/bluetooth_low_energy/utils.cc
diff --git a/extensions/browser/api/bluetooth_low_energy/utils.cc b/extensions/browser/api/bluetooth_low_energy/utils.cc
index 5767b7a6e0410ee45ccb8afdfc0b166621c5dc7e..df97b81e5835b56d52a4d6141fff5dd86fcf909d 100644
--- a/extensions/browser/api/bluetooth_low_energy/utils.cc
+++ b/extensions/browser/api/bluetooth_low_energy/utils.cc
@@ -37,8 +37,8 @@ std::unique_ptr<base::DictionaryValue> CharacteristicToValue(
std::vector<CharacteristicProperty> properties = from->properties;
from->properties.clear();
std::unique_ptr<base::DictionaryValue> to = from->ToValue();
- to->SetWithoutPathExpansion(
- "properties", CharacteristicPropertiesToValue(properties).release());
+ to->SetWithoutPathExpansion("properties",
+ CharacteristicPropertiesToValue(properties));
return to;
}
@@ -56,7 +56,7 @@ std::unique_ptr<base::DictionaryValue> DescriptorToValue(Descriptor* from) {
to->GetDictionaryWithoutPathExpansion("characteristic", &chrc_value);
DCHECK(chrc_value);
chrc_value->SetWithoutPathExpansion(
- "properties", CharacteristicPropertiesToValue(properties).release());
+ "properties", CharacteristicPropertiesToValue(properties));
return to;
}
« no previous file with comments | « dbus/values_util_unittest.cc ('k') | ios/chrome/browser/autofill/autofill_agent.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698