Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: tools/json_schema_compiler/test/enums_unittest.cc

Issue 2884933002: Remove raw base::DictionaryValue::SetWithoutPathExpansion (Closed)
Patch Set: Include Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/enums_unittest.cc
diff --git a/tools/json_schema_compiler/test/enums_unittest.cc b/tools/json_schema_compiler/test/enums_unittest.cc
index 5318981ba224f9388562015673de5c2b1aa9b005..715b4aef6797ad583d883c40070c99026eee9c87 100644
--- a/tools/json_schema_compiler/test/enums_unittest.cc
+++ b/tools/json_schema_compiler/test/enums_unittest.cc
@@ -4,6 +4,8 @@
#include "tools/json_schema_compiler/test/enums.h"
+#include "base/memory/ptr_util.h"
+#include "base/values.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "tools/json_schema_compiler/test/test_util.h"
@@ -72,7 +74,8 @@ TEST(JsonSchemaCompilerEnumsTest, EnumsAsTypes) {
TEST(JsonSchemaCompilerEnumsTest, EnumsArrayAsType) {
{
base::ListValue params_value;
- params_value.Append(List(new base::Value("one"), new base::Value("two")));
+ params_value.Append(List(base::MakeUnique<base::Value>("one"),
+ base::MakeUnique<base::Value>("two")));
std::unique_ptr<TakesEnumArrayAsType::Params> params(
TakesEnumArrayAsType::Params::Create(params_value));
ASSERT_TRUE(params);
@@ -82,7 +85,7 @@ TEST(JsonSchemaCompilerEnumsTest, EnumsArrayAsType) {
}
{
base::ListValue params_value;
- params_value.Append(List(new base::Value("invalid")));
+ params_value.Append(List(base::MakeUnique<base::Value>("invalid")));
std::unique_ptr<TakesEnumArrayAsType::Params> params(
TakesEnumArrayAsType::Params::Create(params_value));
EXPECT_FALSE(params);
@@ -162,7 +165,8 @@ TEST(JsonSchemaCompilerEnumsTest, TakesEnumParamsCreate) {
TEST(JsonSchemaCompilerEnumsTest, TakesEnumArrayParamsCreate) {
{
base::ListValue params_value;
- params_value.Append(List(new base::Value("one"), new base::Value("two")));
+ params_value.Append(List(base::MakeUnique<base::Value>("one"),
+ base::MakeUnique<base::Value>("two")));
std::unique_ptr<TakesEnumArray::Params> params(
TakesEnumArray::Params::Create(params_value));
ASSERT_TRUE(params);
@@ -172,7 +176,7 @@ TEST(JsonSchemaCompilerEnumsTest, TakesEnumArrayParamsCreate) {
}
{
base::ListValue params_value;
- params_value.Append(List(new base::Value("invalid")));
+ params_value.Append(List(base::MakeUnique<base::Value>("invalid")));
std::unique_ptr<TakesEnumArray::Params> params(
TakesEnumArray::Params::Create(params_value));
EXPECT_FALSE(params);
« no previous file with comments | « tools/json_schema_compiler/test/choices_unittest.cc ('k') | tools/json_schema_compiler/test/error_generation_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698