Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/json_schema_compiler/test/simple_api_unittest.cc

Issue 2884933002: Remove raw base::DictionaryValue::SetWithoutPathExpansion (Closed)
Patch Set: Include Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/simple_api_unittest.cc
diff --git a/tools/json_schema_compiler/test/simple_api_unittest.cc b/tools/json_schema_compiler/test/simple_api_unittest.cc
index 54c773f2174c51f8a780ec1e4668796d49f86c72..ef6f9e20518dbf9448ff517a486c149563713600 100644
--- a/tools/json_schema_compiler/test/simple_api_unittest.cc
+++ b/tools/json_schema_compiler/test/simple_api_unittest.cc
@@ -5,6 +5,7 @@
#include "tools/json_schema_compiler/test/simple_api.h"
#include "base/memory/ptr_util.h"
+#include "base/values.h"
#include "testing/gtest/include/gtest/gtest.h"
using namespace test::api::simple_api;
@@ -13,10 +14,10 @@ namespace {
static std::unique_ptr<base::DictionaryValue> CreateTestTypeDictionary() {
std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue());
- value->SetWithoutPathExpansion("number", new base::Value(1.1));
- value->SetWithoutPathExpansion("integer", new base::Value(4));
- value->SetWithoutPathExpansion("string", new base::Value("bling"));
- value->SetWithoutPathExpansion("boolean", new base::Value(true));
+ value->SetDoubleWithoutPathExpansion("number", 1.1);
+ value->SetIntegerWithoutPathExpansion("integer", 4);
+ value->SetStringWithoutPathExpansion("string", "bling");
+ value->SetBooleanWithoutPathExpansion("boolean", true);
return value;
}
« no previous file with comments | « tools/json_schema_compiler/test/error_generation_unittest.cc ('k') | tools/json_schema_compiler/test/test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698