Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2889603002: supersize: Add "printed" to console, Show ~0 for PSS >0 <.1 (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

supersize: Add "printed" to console, show ~0 when 0<PSS<0.05 Also: Don't include "foo/{shared}/2" in unique path count. Also: Reset "Symbol Gap #" counter for each section. Examples: Review-Url: https://codereview.chromium.org/2889603002 Cr-Commit-Position: refs/heads/master@{#472112} Committed: https://chromium.googlesource.com/chromium/src/+/b86f0dedd2c6ba1eaa6438373439dfce5291c3cf

Patch Set 1 #

Patch Set 2 : add in Symbol Group counter reset #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -94 lines) Patch
M tools/binary_size/libsupersize/console.py View 6 chunks +10 lines, -3 lines 0 comments Download
M tools/binary_size/libsupersize/describe.py View 3 chunks +6 lines, -2 lines 2 comments Download
M tools/binary_size/libsupersize/linker_map_parser.py View 1 2 chunks +1 line, -1 line 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive.golden View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive_Elf.golden View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive_OutputDirectory.golden View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Console.golden View 1 7 chunks +9 lines, -9 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_Basic.golden View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_NullDiff.golden View 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/libsupersize/testdata/FullDescription.golden View 1 4 chunks +5 lines, -5 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/SymbolGroupMethods.golden View 1 8 chunks +58 lines, -58 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
agrieve
On 2017/05/16 14:41:41, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 🎲
3 years, 7 months ago (2017-05-16 14:41:49 UTC) #3
estevenson
lgtm https://codereview.chromium.org/2889603002/diff/20001/tools/binary_size/libsupersize/describe.py File tools/binary_size/libsupersize/describe.py (right): https://codereview.chromium.org/2889603002/diff/20001/tools/binary_size/libsupersize/describe.py#newcode41 tools/binary_size/libsupersize/describe.py:41: ret = '~0' nit: won't this actually only ...
3 years, 7 months ago (2017-05-16 15:11:08 UTC) #5
agrieve
https://codereview.chromium.org/2889603002/diff/20001/tools/binary_size/libsupersize/describe.py File tools/binary_size/libsupersize/describe.py (right): https://codereview.chromium.org/2889603002/diff/20001/tools/binary_size/libsupersize/describe.py#newcode41 tools/binary_size/libsupersize/describe.py:41: ret = '~0' On 2017/05/16 15:11:07, estevenson wrote: > ...
3 years, 7 months ago (2017-05-16 15:22:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889603002/20001
3 years, 7 months ago (2017-05-16 15:23:06 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 15:36:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b86f0dedd2c6ba1eaa6438373439...

Powered by Google App Engine
This is Rietveld 408576698