tools/binary_size/diagnose_bloat.py - Issue 2884283002: supersize: Fix diff logic for changed vs unchanged of groups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/binary_size/diagnose_bloat.py

Issue 2884283002: supersize: Fix diff logic for changed vs unchanged of groups (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/binary_size/diagnose_bloat.py

diff --git a/tools/binary_size/diagnose_bloat.py b/tools/binary_size/diagnose_bloat.py

index dd7109ed67feded2e5ad115f667fb479745d45d9..14923b53e1204607038fbc2ef09df8ec88de63d6 100755

--- a/tools/binary_size/diagnose_bloat.py

+++ b/tools/binary_size/diagnose_bloat.py

@@ -77,9 +77,7 @@ class BaseDiff(object):

class NativeDiff(BaseDiff):

- _RE_SUMMARY = re.compile(

- r'.*(Section Sizes .*? object files added, \d+ removed).*',

- flags=re.DOTALL)

+ _RE_SUMMARY = re.compile(r'Section Sizes .*?\n\n.*?(?=\n\n)', flags=re.DOTALL)

_RE_SUMMARY_STAT = re.compile(

r'Section Sizes \(Total=(?P<value>\d+) (?P<units>\w+)\)')

_SUMMARY_STAT_NAME = 'Native Library Delta'

@@ -102,7 +100,7 @@ class NativeDiff(BaseDiff):

return self._diff.splitlines()

def Summary(self):

- return NativeDiff._RE_SUMMARY.match(self._diff).group(1)

+ return NativeDiff._RE_SUMMARY.search(self._diff).group()

def ProduceDiff(self, before_dir, after_dir):

before_size = os.path.join(before_dir, self._size_name)

« no previous file with comments | « no previous file | tools/binary_size/libsupersize/describe.py » ('j') | no next file with comments »