[ios] Convert //ios/chrome/browser/tabs target to ARC.

[ios] Convert //ios/chrome/browser/tabs target to ARC.

BUG=None

Review-Url: https://codereview.chromium.org/2884213002
Cr-Commit-Position: refs/heads/master@{#473924}
Committed: https://chromium.googlesource.com/chromium/src/+/85c062fd6ce24e1c031c035c71a28b42b00d9934

[sdefresne, 2017-05-16 09:39:01]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 09:39:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-05-16 09:40:11]

sdefresne@chromium.org changed reviewers:
+ stkhapugin@chromium.org

[sdefresne, 2017-05-16 09:40:12]

This target only contains header file, so no need to change the file themselves.
PTAL

[stkhapugin, 2017-05-16 09:49:01]

Please tell me if these comments are addressed in a previous CL and I just need
to rebase

https://codereview.chromium.org/2884213002/diff/1/ios/chrome/browser/tabs/BUI...
File ios/chrome/browser/tabs/BUILD.gn (right):

https://codereview.chromium.org/2884213002/diff/1/ios/chrome/browser/tabs/BUI...
ios/chrome/browser/tabs/BUILD.gn:8: "tab.h",
This file has a bunch of properties that have no storage classificators or have
assign for objc objects

https://codereview.chromium.org/2884213002/diff/1/ios/chrome/browser/tabs/BUI...
ios/chrome/browser/tabs/BUILD.gn:13: "tab_model.h",
ditto

https://codereview.chromium.org/2884213002/diff/1/ios/chrome/browser/tabs/BUI...
ios/chrome/browser/tabs/BUILD.gn:16: "tab_model_synced_window_delegate.h",
This one has an ivar in a header that's marked as "// weak, owns us" and is
objc, so you need an __unsafe_unretained there

[sdefresne, 2017-05-16 10:06:47]

https://codereview.chromium.org/2884213002/diff/1/ios/chrome/browser/tabs/BUI...
File ios/chrome/browser/tabs/BUILD.gn (right):

https://codereview.chromium.org/2884213002/diff/1/ios/chrome/browser/tabs/BUI...
ios/chrome/browser/tabs/BUILD.gn:8: "tab.h",
On 2017/05/16 09:49:01, stkhapugin wrote:
> This file has a bunch of properties that have no storage classificators or
have
> assign for objc objects
>  

The only assign properties are for non-objc objects:
@property(nonatomic, assign) BOOL useGreyImageCache;
@property(nonatomic, assign) BOOL isPrerenderTab;
@property(nonatomic, assign) BOOL isLinkLoadingPrerenderTab;
@property(nonatomic, assign) BOOL isVoiceSearchResultsTab;

The properties without a specifier are properties that are not synthesized
(title, originalTitle, webController) or are strong (as this is the default,
like tabId, passwordController, ...).

This was done in https://codereview.chromium.org/2857133002/.

https://codereview.chromium.org/2884213002/diff/1/ios/chrome/browser/tabs/BUI...
ios/chrome/browser/tabs/BUILD.gn:13: "tab_model.h",
On 2017/05/16 09:49:01, stkhapugin wrote:
> ditto

Ditto, except the CL is https://codereview.chromium.org/2854133002/.

https://codereview.chromium.org/2884213002/diff/1/ios/chrome/browser/tabs/BUI...
ios/chrome/browser/tabs/BUILD.gn:16: "tab_model_synced_window_delegate.h",
On 2017/05/16 09:49:01, stkhapugin wrote:
> This one has an ivar in a header that's marked as "// weak, owns us" and is
> objc, so you need an __unsafe_unretained there

This no longer has any Objective-C member fields since
https://codereview.chromium.org/2845353002/.

[commit-bot: I haz the power, 2017-05-16 10:38:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 10:39:00]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2017-05-16 11:24:35]

lgtm

[sdefresne, 2017-05-23 14:50:27]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-05-23 14:50:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org
Link to the patchset: https://codereview.chromium.org/2884213002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-23 14:50:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 16:09:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495551027185620,
"parent_rev": "83bd4fc4a3867df2afb401a4fcd8096dfc210a2e", "commit_rev":
"85c062fd6ce24e1c031c035c71a28b42b00d9934"}

[commit-bot: I haz the power, 2017-05-23 16:09:32]

Description was changed from

==========
[ios] Convert //ios/chrome/browser/tabs target to ARC.

BUG=None
==========

to

==========
[ios] Convert //ios/chrome/browser/tabs target to ARC.

BUG=None

Review-Url: https://codereview.chromium.org/2884213002
Cr-Commit-Position: refs/heads/master@{#473924}
Committed:
https://chromium.googlesource.com/chromium/src/+/85c062fd6ce24e1c031c035c71a2...
==========

[commit-bot: I haz the power, 2017-05-23 16:09:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/85c062fd6ce24e1c031c035c71a2...