Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2845353002: [ios] ARCMigrate i/c/b/tabs/tab_model_synced_window_delegate*. (Closed)

Created:
3 years, 7 months ago by sdefresne
Modified:
3 years, 7 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] ARCMigrate i/c/b/tabs/tab_model_synced_window_delegate*. Convert TabModelSyncedWindowDelegate to use WebStateList instead of TabModel and convert the file to ARC (i.e. add the ARC header guard). BUG=None Review-Url: https://codereview.chromium.org/2845353002 Cr-Commit-Position: refs/heads/master@{#470974} Committed: https://chromium.googlesource.com/chromium/src/+/91e46a676a288cdcc42798867f9658d14e708268

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M ios/chrome/browser/tabs/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model_synced_window_delegate.h View 3 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model_synced_window_delegate.mm View 3 chunks +15 lines, -18 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model_synced_window_delegate_getter.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
sdefresne
stkhapugin: please take a look. rohitrao: FYI
3 years, 7 months ago (2017-04-28 14:04:47 UTC) #4
stkhapugin
lgtm
3 years, 7 months ago (2017-05-02 12:32:23 UTC) #7
rohitrao (ping after 24h)
I get an "old chunk mismatch" on the BUILD.gn changes. Do you see it as ...
3 years, 7 months ago (2017-05-04 10:46:27 UTC) #8
rohitrao (ping after 24h)
lgtm but I'd like to see the GN changes https://codereview.chromium.org/2845353002/diff/1/ios/chrome/browser/tabs/tab_model_synced_window_delegate.mm File ios/chrome/browser/tabs/tab_model_synced_window_delegate.mm (left): https://codereview.chromium.org/2845353002/diff/1/ios/chrome/browser/tabs/tab_model_synced_window_delegate.mm#oldcode31 ios/chrome/browser/tabs/tab_model_synced_window_delegate.mm:31: ...
3 years, 7 months ago (2017-05-04 10:50:05 UTC) #9
sdefresne
Thank you for the review. https://codereview.chromium.org/2845353002/diff/1/ios/chrome/browser/tabs/tab_model_synced_window_delegate.mm File ios/chrome/browser/tabs/tab_model_synced_window_delegate.mm (left): https://codereview.chromium.org/2845353002/diff/1/ios/chrome/browser/tabs/tab_model_synced_window_delegate.mm#oldcode31 ios/chrome/browser/tabs/tab_model_synced_window_delegate.mm:31: if (!delegate) { On ...
3 years, 7 months ago (2017-05-09 13:06:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845353002/40001
3 years, 7 months ago (2017-05-11 15:25:42 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 16:34:04 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/91e46a676a288cdcc42798867f96...

Powered by Google App Engine
This is Rietveld 408576698