Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright 2016 The Chromium Authors. All rights reserved. | 1 # Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 source_set("tabs") { | 5 source_set("tabs") { |
| 6 sources = [ | 6 sources = [ |
| 7 "legacy_tab_helper.h", | 7 "legacy_tab_helper.h", |
| 8 "tab.h", | 8 "tab.h", |
|
stkhapugin
2017/05/16 09:49:01
This file has a bunch of properties that have no s
sdefresne
2017/05/16 10:06:47
The only assign properties are for non-objc object
| |
| 9 "tab_delegate.h", | 9 "tab_delegate.h", |
| 10 "tab_dialog_delegate.h", | 10 "tab_dialog_delegate.h", |
| 11 "tab_headers_delegate.h", | 11 "tab_headers_delegate.h", |
| 12 "tab_helper_util.h", | 12 "tab_helper_util.h", |
| 13 "tab_model.h", | 13 "tab_model.h", |
|
stkhapugin
2017/05/16 09:49:01
ditto
sdefresne
2017/05/16 10:06:47
Ditto, except the CL is https://codereview.chromiu
| |
| 14 "tab_model_list.h", | 14 "tab_model_list.h", |
| 15 "tab_model_observer.h", | 15 "tab_model_observer.h", |
| 16 "tab_model_synced_window_delegate.h", | 16 "tab_model_synced_window_delegate.h", |
|
stkhapugin
2017/05/16 09:49:01
This one has an ivar in a header that's marked as
sdefresne
2017/05/16 10:06:47
This no longer has any Objective-C member fields s
| |
| 17 "tab_model_synced_window_delegate_getter.h", | 17 "tab_model_synced_window_delegate_getter.h", |
| 18 "tab_private.h", | 18 "tab_private.h", |
| 19 "tab_snapshotting_delegate.h", | 19 "tab_snapshotting_delegate.h", |
| 20 ] | 20 ] |
| 21 public_deps = [ | 21 public_deps = [ |
| 22 "//ios/web", | 22 "//ios/web", |
| 23 ] | 23 ] |
| 24 deps = [ | 24 deps = [ |
| 25 "//components/sessions", | 25 "//components/sessions", |
| 26 "//components/signin/ios/browser", | 26 "//components/signin/ios/browser", |
| 27 "//components/sync_sessions", | 27 "//components/sync_sessions", |
| 28 "//ios/chrome/browser/web:sad_tab_tab_helper_delegate", | 28 "//ios/chrome/browser/web:sad_tab_tab_helper_delegate", |
| 29 "//ios/net", | 29 "//ios/net", |
| 30 "//ios/web:user_agent", | 30 "//ios/web:user_agent", |
| 31 "//ui/base", | 31 "//ui/base", |
| 32 ] | 32 ] |
| 33 libs = [ "UIKit.framework" ] | 33 libs = [ "UIKit.framework" ] |
| 34 configs += [ "//build/config/compiler:enable_arc" ] | |
| 34 } | 35 } |
| 35 | 36 |
| 36 source_set("tabs_internal") { | 37 source_set("tabs_internal") { |
| 37 sources = [ | 38 sources = [ |
| 38 "legacy_tab_helper.mm", | 39 "legacy_tab_helper.mm", |
| 39 "tab.h", | 40 "tab.h", |
| 40 "tab.mm", | 41 "tab.mm", |
| 41 "tab_helper_util.mm", | 42 "tab_helper_util.mm", |
| 42 "tab_model.mm", | 43 "tab_model.mm", |
| 43 "tab_model_closing_web_state_observer.h", | 44 "tab_model_closing_web_state_observer.h", |
| (...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 185 ":tabs", | 186 ":tabs", |
| 186 ":tabs_internal", | 187 ":tabs_internal", |
| 187 "//base", | 188 "//base", |
| 188 "//ios/chrome/browser/browser_state:test_support", | 189 "//ios/chrome/browser/browser_state:test_support", |
| 189 "//ios/chrome/browser/sessions:test_support", | 190 "//ios/chrome/browser/sessions:test_support", |
| 190 "//ios/web:test_support", | 191 "//ios/web:test_support", |
| 191 "//testing/gtest", | 192 "//testing/gtest", |
| 192 ] | 193 ] |
| 193 configs += [ "//build/config/compiler:enable_arc" ] | 194 configs += [ "//build/config/compiler:enable_arc" ] |
| 194 } | 195 } |
| OLD | NEW |