Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2886763003: [ios] Convert //ios/chrome/browser/tabs:unit_tests to ARC. (Closed)

Created:
3 years, 7 months ago by sdefresne
Modified:
3 years, 7 months ago
Reviewers:
lpromero
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Convert //ios/chrome/browser/tabs:unit_tests to ARC. BUG=None Review-Url: https://codereview.chromium.org/2886763003 Cr-Commit-Position: refs/heads/master@{#473940} Committed: https://chromium.googlesource.com/chromium/src/+/5634194e49b9dee7385e757ecdd4bd9fd2206065

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -94 lines) Patch
M ios/chrome/browser/tabs/BUILD.gn View 2 chunks +1 line, -17 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model_unittest.mm View 13 chunks +34 lines, -33 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 14 chunks +42 lines, -44 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (14 generated)
sdefresne
Please take a look.
3 years, 7 months ago (2017-05-23 15:29:02 UTC) #11
lpromero
lgtm
3 years, 7 months ago (2017-05-23 15:41:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886763003/20001
3 years, 7 months ago (2017-05-23 16:12:39 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 16:53:19 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5634194e49b9dee7385e757ecdd4...

Powered by Google App Engine
This is Rietveld 408576698