Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2883073002: Remove selected text when committing empty text (Closed)

Created:
3 years, 7 months ago by Changwan Ryu
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, jam, kinuko+watch, darin-cc_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Remove selected text when committing empty text Android's InputConnection API does not mention this, but replacing the selected text by the new text seems to be the right behavior and is consistent with EditText behavior. Also, this is consistent with SetComposition()'s behavior for empty string. In doing so, - fix Editor to handle empty text and emit beforeinput event as expected (https://w3c.github.io/uievents/#beforeinput mentions empty string case) - remove unnecessary code in WebLocalFrameImpl to fix test failures. BUG=710621 Review-Url: https://codereview.chromium.org/2874783004 Cr-Original-Commit-Position: refs/heads/master@{#471228} Review-Url: https://codereview.chromium.org/2883073002 . Cr-Commit-Position: refs/branch-heads/3071@{#555} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/d48ab8de17a217029d45a9c7f9d73466cb747fad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -28 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 2 chunks +9 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 2 chunks +17 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Changwan Ryu
3 years, 7 months ago (2017-05-15 17:10:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d48ab8de17a217029d45a9c7f9d73466cb747fad.

Powered by Google App Engine
This is Rietveld 408576698