Remove selected text when committing empty text

Remove selected text when committing empty text

Android's InputConnection API does not mention this, but replacing the
selected text by the new text seems to be the right behavior and is
consistent with EditText behavior. Also, this is consistent with
SetComposition()'s behavior for empty string.

In doing so,
- fix Editor to handle empty text and emit beforeinput event as expected
  (https://w3c.github.io/uievents/#beforeinput mentions empty string
  case)
- remove unnecessary code in WebLocalFrameImpl to fix test failures.

BUG=710621
Review-Url: https://codereview.chromium.org/2874783004
Cr-Commit-Position: refs/heads/master@{#471228}
Committed: https://chromium.googlesource.com/chromium/src/+/79067c775b1196aa0be445effa8109d85ca82b68

[Changwan Ryu, 2017-05-11 08:57:11]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 08:57:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Changwan Ryu, 2017-05-11 09:13:26]

changwan@chromium.org changed reviewers:
+ aelias@chromium.org, yosin@chromium.org

[Changwan Ryu, 2017-05-11 09:13:26]

PTAL.

[commit-bot: I haz the power, 2017-05-11 12:19:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 12:19:57]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2017-05-11 19:09:57]

lgtm, thanks.  Over to yosin@ for OWNERS.

Right, there has been a lot of pain originating from the fact that on Windows,
commitText("") means cancel and do nothing, but on Android, it means "replace
with nothing".  IMO, the Android semantics are cleaner and more principled.  And
nowadays, on the Windows browser-side code, empty-string commits are forwarded
to finishComposingText instead:
https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_wid...
, so there is no need to support the Windows semantics on the Blink side
anymore.  yabinh@ tried to clean them up but it looks like you found some more
residue.

[yosin_UTC9, 2017-05-12 05:06:14]

lgtm

Thanks for simplify the code.
This is good patch since fixing an issue and cleanup the code!
(^_^)b

https://codereview.chromium.org/2874783004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/2874783004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/Editor.cpp:1063: !text.IsEmpty() &&
IsSpaceOrNewline(text[0]));
Good catch!

[Changwan Ryu, 2017-05-12 05:26:21]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2017-05-12 05:26:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 05:32:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494566781257150, "parent_rev":
"fb293a5d27d9f233a801653e4983bef0a92e43e9", "commit_rev":
"79067c775b1196aa0be445effa8109d85ca82b68"}

[commit-bot: I haz the power, 2017-05-12 05:33:03]

Description was changed from

==========
Remove selected text when committing empty text

Android's InputConnection API does not mention this, but replacing the
selected text by the new text seems to be the right behavior and is
consistent with EditText behavior. Also, this is consistent with
SetComposition()'s behavior for empty string.

In doing so,
- fix Editor to handle empty text and emit beforeinput event as expected
  (https://w3c.github.io/uievents/#beforeinput mentions empty string
  case)
- remove unnecessary code in WebLocalFrameImpl to fix test failures.

BUG=710621
==========

to

==========
Remove selected text when committing empty text

Android's InputConnection API does not mention this, but replacing the
selected text by the new text seems to be the right behavior and is
consistent with EditText behavior. Also, this is consistent with
SetComposition()'s behavior for empty string.

In doing so,
- fix Editor to handle empty text and emit beforeinput event as expected
  (https://w3c.github.io/uievents/#beforeinput mentions empty string
  case)
- remove unnecessary code in WebLocalFrameImpl to fix test failures.

BUG=710621

Review-Url: https://codereview.chromium.org/2874783004
Cr-Commit-Position: refs/heads/master@{#471228}
Committed:
https://chromium.googlesource.com/chromium/src/+/79067c775b1196aa0be445effa81...
==========

[commit-bot: I haz the power, 2017-05-12 05:33:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/79067c775b1196aa0be445effa81...