Remove selected text when committing empty text

third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/InputMethodController.h"
 
 #include <memory>
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/Range.h"
@@ skipping 1254 matching lines @@
   CreateHTMLWithCompositionInputEventListeners();
 
   // Simulate composition in the |contentEditable|.
   Vector<CompositionUnderline> underlines;
   underlines.push_back(CompositionUnderline(0, 5, Color(255, 0, 0), false, 0));
 
   // Insert empty text without previous composition.
   GetDocument().setTitle(g_empty_string);
   GetDocument().UpdateStyleAndLayout();
   Controller().CommitText("", underlines, 0);
-  EXPECT_STREQ("", GetDocument().title().Utf8().Data());
+  EXPECT_STREQ("beforeinput.data:;", GetDocument().title().Utf8().Data());
 
   GetDocument().setTitle(g_empty_string);
   Controller().SetComposition("n", underlines, 1, 1);
   EXPECT_STREQ("beforeinput.data:n;input.data:n;",
                GetDocument().title().Utf8().Data());
 
   // Insert empty text with previous composition.
   GetDocument().setTitle(g_empty_string);
   GetDocument().UpdateStyleAndLayout();
   Controller().CommitText("", underlines, 1);
@@ skipping 214 matching lines @@
   EXPECT_STREQ("&nbsp;text blah", div->innerHTML().Utf8().Data());
 
   // Delete "blah"
   Controller().SetCompositionFromExistingText(empty_underlines, 6, 10);
   Controller().CommitText(String(""), empty_underlines, 0);
 
   // The space at the end of the string should have been converted to an nbsp
   EXPECT_STREQ("&nbsp;text&nbsp;", div->innerHTML().Utf8().Data());
 }
 
+TEST_F(InputMethodControllerTest, CommitEmptyTextDeletesSelection) {
+  HTMLInputElement* input =
+      toHTMLInputElement(InsertHTMLElement("<input id='sample'>", "sample"));
+
+  input->setValue("Abc Def Ghi");
+  GetDocument().UpdateStyleAndLayout();
+  Vector<CompositionUnderline> empty_underlines;
+  Controller().SetEditableSelectionOffsets(PlainTextRange(4, 8));
+  Controller().CommitText(String(""), empty_underlines, 0);
+  EXPECT_STREQ("Abc Ghi", input->value().Utf8().Data());
+
+  Controller().SetEditableSelectionOffsets(PlainTextRange(4, 7));
+  Controller().CommitText(String("1"), empty_underlines, 0);
+  EXPECT_STREQ("Abc 1", input->value().Utf8().Data());
+}
+
 static String GetMarkedText(
     DocumentMarkerController& document_marker_controller,
     Node* node,
     int marker_index) {
   DocumentMarker* marker = document_marker_controller.Markers()[marker_index];
   return node->textContent().Substring(
       marker->StartOffset(), marker->EndOffset() - marker->StartOffset());
 }
 
 TEST_F(InputMethodControllerTest,
@@ skipping 452 matching lines @@
   // Set selection before BODY(editable).
   GetFrame().Selection().SetSelection(
       SelectionInDOMTree::Builder()
           .Collapse(Position(GetDocument().documentElement(), 0))
           .Build());
 
   EXPECT_EQ(kWebTextInputTypeContentEditable, Controller().TextInputType());
 }
 
 }  // namespace blink