Remove selected text when committing empty text

third_party/WebKit/Source/core/editing/InputMethodController.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 391 matching lines @@
 
 bool InputMethodController::CommitText(
     const String& text,
     const Vector<CompositionUnderline>& underlines,
     int relative_caret_position) {
   if (HasComposition()) {
     return ReplaceCompositionAndMoveCaret(text, relative_caret_position,
                                           underlines);
   }
 
-  // We should do nothing in this case, because:
-  // 1. No need to insert text when text is empty.
-  // 2. Shouldn't move caret when relativeCaretPosition == 0 to avoid
-  // duplicate selection change event.
-  if (!text.length() && !relative_caret_position)
-    return false;
-
   return InsertTextAndMoveCaret(text, relative_caret_position, underlines);
 }
 
 bool InputMethodController::ReplaceComposition(const String& text) {
   if (!HasComposition())
     return false;
 
   // Select the text that will be deleted or replaced.
   SelectComposition();
 
@@ skipping 91 matching lines @@
 
 bool InputMethodController::InsertTextAndMoveCaret(
     const String& text,
     int relative_caret_position,
     const Vector<CompositionUnderline>& underlines) {
   PlainTextRange selection_range = GetSelectionOffsets();
   if (selection_range.IsNull())
     return false;
   int text_start = selection_range.Start();
 
-  if (text.length()) {
-    if (!InsertText(text))
-      return false;
-
-    Element* root_editable_element =
-        GetFrame()
-            .Selection()
-            .ComputeVisibleSelectionInDOMTreeDeprecated()
-            .RootEditableElement();
-    if (root_editable_element) {
-      AddCompositionUnderlines(underlines, root_editable_element, text_start);
-    }
+  if (!InsertText(text))
+    return false;
+  Element* root_editable_element =
+      GetFrame()
+          .Selection()
+          .ComputeVisibleSelectionInDOMTreeDeprecated()
+          .RootEditableElement();
+  if (root_editable_element) {
+    AddCompositionUnderlines(underlines, root_editable_element, text_start);
   }
 
   int absolute_caret_position = ComputeAbsoluteCaretPosition(
       text_start, text.length(), relative_caret_position);
   return MoveCaret(absolute_caret_position);
 }
 
 void InputMethodController::CancelComposition() {
   if (!HasComposition())
     return;
@@ skipping 695 matching lines @@
   FinishComposingText(kKeepSelection);
 }
 
 DEFINE_TRACE(InputMethodController) {
   visitor->Trace(frame_);
   visitor->Trace(composition_range_);
   SynchronousMutationObserver::Trace(visitor);
 }
 
 }  // namespace blink