Delete unused chrome://fallback-icon/ handling

Delete unused chrome://fallback-icon/ handling

BUG=712475
R=huangs,jkrcal,pkasting
TBR=treib for removal of stray includes in chrome/browser/search/

Review-Url: https://codereview.chromium.org/2883053003
Cr-Commit-Position: refs/heads/master@{#475087}
Committed: https://chromium.googlesource.com/chromium/src/+/59f676347cd7bb0ec16a9cae0e1257f6548dc3b4

[pkotwicz, 2017-05-15 19:40:35]

pkotwicz@chromium.org changed reviewers:
+ huangs@chromium.org, jkrcal@chromium.org

[pkotwicz, 2017-05-15 19:41:25]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2017-05-15 19:42:23]

jkrcal@ and huangs@ can you please take a look? This CL depends on
https://codereview.chromium.org/2885523002/

I think this is the last CL in terms of removing unused code. :)

[huangs, 2017-05-15 20:00:27]

Just need fix comments and clear up BUILD.gn deps.

https://codereview.chromium.org/2883053003/diff/20001/components/favicon/core...
File components/favicon/core/BUILD.gn (left):

https://codereview.chromium.org/2883053003/diff/20001/components/favicon/core...
components/favicon/core/BUILD.gn:37: "//components/keyed_service/core",
These should be updated.  E.g., can probably remove remove keyed_service

https://codereview.chromium.org/2883053003/diff/20001/components/favicon_base...
File components/favicon_base/BUILD.gn (left):

https://codereview.chromium.org/2883053003/diff/20001/components/favicon_base...
components/favicon_base/BUILD.gn:29: "//ui/base",
Please update these.

https://codereview.chromium.org/2883053003/diff/20001/components/favicon_base...
File components/favicon_base/fallback_icon_style.h (right):

https://codereview.chromium.org/2883053003/diff/20001/components/favicon_base...
components/favicon_base/fallback_icon_style.h:14: // rounded square containing a
single letter. The specification excludes the
Comment needs to be updated.

[jkrcal, 2017-05-16 07:13:01]

Awesome, kudos for cleaning up!

lgtm % comment by huangs.

https://codereview.chromium.org/2883053003/diff/20001/components/favicon/core...
File components/favicon/core/BUILD.gn (left):

https://codereview.chromium.org/2883053003/diff/20001/components/favicon/core...
components/favicon/core/BUILD.gn:37: "//components/keyed_service/core",
On 2017/05/15 20:00:26, huangs wrote:
> These should be updated.  E.g., can probably remove remove keyed_service 

I do not see anything that can be removed (e.g. keyed_service is still used by
favicon/large_icon_service).

[pkotwicz, 2017-05-20 21:56:09]

Patchset #3 (id:60001) has been deleted

[pkotwicz, 2017-05-20 21:56:15]

Patchset #2 (id:40001) has been deleted

[pkotwicz, 2017-05-20 21:56:50]

huangs@ can you please take another look?

https://codereview.chromium.org/2883053003/diff/20001/components/favicon_base...
File components/favicon_base/BUILD.gn (left):

https://codereview.chromium.org/2883053003/diff/20001/components/favicon_base...
components/favicon_base/BUILD.gn:29: "//ui/base",
I removed the //skia dependency. I think that's the only think that I can remove

https://codereview.chromium.org/2883053003/diff/20001/components/favicon_base...
File components/favicon_base/fallback_icon_style.h (right):

https://codereview.chromium.org/2883053003/diff/20001/components/favicon_base...
components/favicon_base/fallback_icon_style.h:14: // rounded square containing a
single letter. The specification excludes the
The comment still seems valid actually. Do you have any suggestions on how to
improve it?

[huangs, 2017-05-21 04:19:01]

LGTM. Thanks for removing this!

https://codereview.chromium.org/2883053003/diff/20001/components/favicon_base...
File components/favicon_base/fallback_icon_style.h (right):

https://codereview.chromium.org/2883053003/diff/20001/components/favicon_base...
components/favicon_base/fallback_icon_style.h:14: // rounded square containing a
single letter. The specification excludes the
Ah okay. I suppose SetDominantColorAsBackground() also alludes the fact that the
icon contains text. Will there be more refactoring after this CL?

[pkotwicz, 2017-05-23 15:48:03]

https://codereview.chromium.org/2883053003/diff/20001/components/favicon_base...
File components/favicon_base/fallback_icon_style.h (right):

https://codereview.chromium.org/2883053003/diff/20001/components/favicon_base...
components/favicon_base/fallback_icon_style.h:14: // rounded square containing a
single letter. The specification excludes the
I am not planning on more refactoring after this CL

[pkotwicz, 2017-05-23 15:52:00]

pkotwicz@chromium.org changed reviewers:
+ dbeam@chromium.org

[pkotwicz, 2017-05-23 15:52:01]

trieb@ for chrome/browser/search/ and chrome/renderer/searchbox OWNERS

dbeam@ for chrome/browser/ui/webui/ OWNERS

[Dan Beam, 2017-05-23 16:23:01]

lgtm

[pkotwicz, 2017-05-23 16:44:19]

Description was changed from

==========
Delete unused chrome://fallback-icon/ handling

BUG=712475
==========

to

==========
Delete unused chrome://fallback-icon/ handling

BUG=712475
==========

[pkotwicz, 2017-05-23 16:44:19]

pkotwicz@chromium.org changed reviewers:
+ treib@chromium.org

[pkotwicz, 2017-05-23 16:47:02]

pkotwicz@chromium.org changed reviewers:
+ pkasting@chromium.org

[pkotwicz, 2017-05-23 16:47:03]

pkasting@ for OWNERS rubberstamp
(The chrome/browser/search/ changes solely involve removing stray includes)

[Peter Kasting, 2017-05-23 22:46:16]

RS LGTM

[pkotwicz, 2017-05-24 14:28:05]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-05-24 14:28:06]

The patchset sent to the CQ was uploaded after l-g-t-m from jkrcal@chromium.org
Link to the patchset: https://codereview.chromium.org/2883053003/#ps80001
(title: "Merge branch 'master' into searchbox3")

[commit-bot: I haz the power, 2017-05-24 14:28:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 14:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 14:36:33]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[pkotwicz, 2017-05-25 22:11:37]

Description was changed from

==========
Delete unused chrome://fallback-icon/ handling

BUG=712475
==========

to

==========
Delete unused chrome://fallback-icon/ handling

BUG=712475
R=huangs,jkrcal,pkasting
TBR=treib for removal of stray includes in chrome/browser/search/
==========

[pkotwicz, 2017-05-25 22:11:43]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-05-25 22:12:04]

The CQ bit was unchecked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-05-25 22:12:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkotwicz, 2017-05-25 22:18:44]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-05-25 22:18:44]

The patchset sent to the CQ was uploaded after l-g-t-m from jkrcal@chromium.org,
pkasting@chromium.org, huangs@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2883053003/#ps100001
(title: "Merge branch 'master' into searchbox3")

[commit-bot: I haz the power, 2017-05-25 22:19:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 22:30:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 22:30:42]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[pkotwicz, 2017-05-26 15:46:34]

The CQ bit was checked by pkotwicz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 15:47:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 16:15:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 16:15:55]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[pkotwicz, 2017-05-26 17:50:32]

Patchset #4 (id:120001) has been deleted

[pkotwicz, 2017-05-26 17:50:39]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-05-26 17:50:39]

The patchset sent to the CQ was uploaded after l-g-t-m from jkrcal@chromium.org,
pkasting@chromium.org, huangs@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2883053003/#ps140001
(title: "Merge branch 'master' into searchbox3")

[commit-bot: I haz the power, 2017-05-26 17:51:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 19:28:09]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1495821039055370,
"parent_rev": "b7a527720b277b3ec4af030be6c32e288f0b18c6", "commit_rev":
"59f676347cd7bb0ec16a9cae0e1257f6548dc3b4"}

[commit-bot: I haz the power, 2017-05-26 19:28:23]

Description was changed from

==========
Delete unused chrome://fallback-icon/ handling

BUG=712475
R=huangs,jkrcal,pkasting
TBR=treib for removal of stray includes in chrome/browser/search/
==========

to

==========
Delete unused chrome://fallback-icon/ handling

BUG=712475
R=huangs,jkrcal,pkasting
TBR=treib for removal of stray includes in chrome/browser/search/

Review-Url: https://codereview.chromium.org/2883053003
Cr-Commit-Position: refs/heads/master@{#475087}
Committed:
https://chromium.googlesource.com/chromium/src/+/59f676347cd7bb0ec16a9cae0e12...
==========

[commit-bot: I haz the power, 2017-05-26 19:28:25]

Committed patchset #4 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/59f676347cd7bb0ec16a9cae0e12...