Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: components/favicon/core/BUILD.gn

Issue 2883053003: Delete unused chrome://fallback-icon/ handling (Closed)
Patch Set: Merge branch 'searchbox2' into searchbox3 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 static_library("core") { 5 static_library("core") {
6 sources = [ 6 sources = [
7 "fallback_url_util.cc", 7 "fallback_url_util.cc",
8 "fallback_url_util.h", 8 "fallback_url_util.h",
9 "favicon_client.h", 9 "favicon_client.h",
10 "favicon_driver.cc", 10 "favicon_driver.cc",
(...skipping 16 matching lines...) Expand all
27 ] 27 ]
28 28
29 deps = [ 29 deps = [
30 "//base", 30 "//base",
31 "//base:i18n", 31 "//base:i18n",
32 "//components/bookmarks/browser", 32 "//components/bookmarks/browser",
33 "//components/data_use_measurement/core", 33 "//components/data_use_measurement/core",
34 "//components/favicon_base", 34 "//components/favicon_base",
35 "//components/history/core/browser", 35 "//components/history/core/browser",
36 "//components/image_fetcher/core", 36 "//components/image_fetcher/core",
37 "//components/keyed_service/core", 37 "//components/keyed_service/core",
huangs 2017/05/15 20:00:26 These should be updated. E.g., can probably remov
jkrcal 2017/05/16 07:13:01 I do not see anything that can be removed (e.g. ke
38 "//net:net", 38 "//net:net",
39 "//skia", 39 "//skia",
40 "//ui/base", 40 "//ui/base",
41 "//ui/gfx", 41 "//ui/gfx",
42 "//url", 42 "//url",
43 ] 43 ]
44 if (!is_ios) {
45 deps += [ "//cc/paint" ]
46 sources += [
47 "fallback_icon_client.h",
48 "fallback_icon_service.cc",
49 "fallback_icon_service.h",
50 ]
51 }
52 } 44 }
53 45
54 source_set("unit_tests") { 46 source_set("unit_tests") {
55 testonly = true 47 testonly = true
56 sources = [ 48 sources = [
57 "fallback_url_util_unittest.cc", 49 "fallback_url_util_unittest.cc",
58 "favicon_handler_unittest.cc", 50 "favicon_handler_unittest.cc",
59 "favicon_service_impl_unittest.cc", 51 "favicon_service_impl_unittest.cc",
60 "large_icon_service_unittest.cc", 52 "large_icon_service_unittest.cc",
61 ] 53 ]
(...skipping 10 matching lines...) Expand all
72 "//components/variations:test_support", 64 "//components/variations:test_support",
73 "//skia", 65 "//skia",
74 "//testing/gmock", 66 "//testing/gmock",
75 "//testing/gtest", 67 "//testing/gtest",
76 "//ui/base", 68 "//ui/base",
77 "//ui/gfx", 69 "//ui/gfx",
78 "//ui/gfx:test_support", 70 "//ui/gfx:test_support",
79 "//url", 71 "//url",
80 ] 72 ]
81 } 73 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698