Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: components/favicon_base/BUILD.gn

Issue 2883053003: Delete unused chrome://fallback-icon/ handling (Closed)
Patch Set: Merge branch 'searchbox2' into searchbox3 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 static_library("favicon_base") { 5 static_library("favicon_base") {
6 sources = [ 6 sources = [
7 "fallback_icon_style.cc", 7 "fallback_icon_style.cc",
8 "fallback_icon_style.h", 8 "fallback_icon_style.h",
9 "fallback_icon_url_parser.cc",
10 "fallback_icon_url_parser.h",
11 "favicon_callback.h", 9 "favicon_callback.h",
12 "favicon_types.cc", 10 "favicon_types.cc",
13 "favicon_types.h", 11 "favicon_types.h",
14 "favicon_url_parser.cc", 12 "favicon_url_parser.cc",
15 "favicon_url_parser.h", 13 "favicon_url_parser.h",
16 "favicon_usage_data.cc", 14 "favicon_usage_data.cc",
17 "favicon_usage_data.h", 15 "favicon_usage_data.h",
18 "favicon_util.cc", 16 "favicon_util.cc",
19 "favicon_util.h", 17 "favicon_util.h",
20 "large_icon_url_parser.cc", 18 "large_icon_url_parser.cc",
21 "large_icon_url_parser.h", 19 "large_icon_url_parser.h",
22 "select_favicon_frames.cc", 20 "select_favicon_frames.cc",
23 "select_favicon_frames.h", 21 "select_favicon_frames.h",
24 ] 22 ]
25 23
26 deps = [ 24 deps = [
27 "//base", 25 "//base",
28 "//net", 26 "//net",
29 "//ui/base", 27 "//ui/base",
huangs 2017/05/15 20:00:26 Please update these.
pkotwicz 2017/05/20 21:56:49 I removed the //skia dependency. I think that's th
30 "//ui/base:ui_data_pack", 28 "//ui/base:ui_data_pack",
31 "//ui/gfx", 29 "//ui/gfx",
32 "//ui/gfx/geometry", 30 "//ui/gfx/geometry",
33 "//url", 31 "//url",
34 ] 32 ]
35 public_deps = [ 33 public_deps = [
36 "//skia", 34 "//skia",
37 ] 35 ]
38 } 36 }
39 37
40 source_set("unit_tests") { 38 source_set("unit_tests") {
41 testonly = true 39 testonly = true
42 sources = [ 40 sources = [
43 "fallback_icon_url_parser_unittest.cc",
44 "favicon_url_parser_unittest.cc", 41 "favicon_url_parser_unittest.cc",
45 "large_icon_url_parser_unittest.cc", 42 "large_icon_url_parser_unittest.cc",
46 "select_favicon_frames_unittest.cc", 43 "select_favicon_frames_unittest.cc",
47 ] 44 ]
48 45
49 deps = [ 46 deps = [
50 ":favicon_base", 47 ":favicon_base",
51 "//testing/gtest", 48 "//testing/gtest",
52 "//ui/base", 49 "//ui/base",
53 "//ui/gfx", 50 "//ui/gfx",
54 "//ui/gfx/geometry", 51 "//ui/gfx/geometry",
55 "//url", 52 "//url",
56 ] 53 ]
57 } 54 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698