| OLD | NEW |
|---|
| (Empty) |
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "components/favicon_base/fallback_icon_url_parser.h" | |
| 6 | |
| 7 #include <stddef.h> | |
| 8 | |
| 9 #include "base/macros.h" | |
| 10 #include "components/favicon_base/fallback_icon_style.h" | |
| 11 #include "testing/gtest/include/gtest/gtest.h" | |
| 12 #include "third_party/skia/include/core/SkColor.h" | |
| 13 #include "ui/gfx/favicon_size.h" | |
| 14 #include "url/gurl.h" | |
| 15 | |
| 16 using chrome::ParsedFallbackIconPath; | |
| 17 using favicon_base::FallbackIconStyle; | |
| 18 | |
| 19 namespace chrome { | |
| 20 | |
| 21 namespace { | |
| 22 | |
| 23 // Default values for FallbackIconStyle, from | |
| 24 // /components/favicon_base/fallback_icon_style.h | |
| 25 const SkColor kDefaultBackgroundColor = SkColorSetRGB(0x78, 0x78, 0x78); | |
| 26 const SkColor kDefaultTextColorDark = SK_ColorBLACK; | |
| 27 const SkColor kDefaultTextColorLight = SK_ColorWHITE; | |
| 28 const double kDefaultFontSizeRatio = 0.44; | |
| 29 const double kDefaultRoundness = 0; | |
| 30 | |
| 31 const char kTestUrlStr[] = "https://www.google.ca/imghp?hl=en&tab=wi"; | |
| 32 | |
| 33 } // namespace | |
| 34 | |
| 35 class FallbackIconUrlParserTest : public testing::Test { | |
| 36 public: | |
| 37 FallbackIconUrlParserTest() { | |
| 38 } | |
| 39 | |
| 40 bool ParseSpecs(const std::string& specs_str, | |
| 41 int *size, | |
| 42 favicon_base::FallbackIconStyle* style) { | |
| 43 return ParsedFallbackIconPath::ParseSpecs(specs_str, size, style); | |
| 44 } | |
| 45 | |
| 46 bool ParseColor(const std::string& color_str, SkColor* color) { | |
| 47 return ParsedFallbackIconPath::ParseColor(color_str, color); | |
| 48 } | |
| 49 | |
| 50 private: | |
| 51 DISALLOW_COPY_AND_ASSIGN(FallbackIconUrlParserTest); | |
| 52 }; | |
| 53 | |
| 54 TEST_F(FallbackIconUrlParserTest, ParseColorSuccess) { | |
| 55 SkColor c; | |
| 56 EXPECT_TRUE(ParseColor("31aBf0f4", &c)); | |
| 57 EXPECT_EQ(SkColorSetARGB(0x31, 0xAB, 0xF0, 0xF4), c); | |
| 58 EXPECT_TRUE(ParseColor("01aBf0", &c)); | |
| 59 EXPECT_EQ(SkColorSetRGB(0x01, 0xAB, 0xF0), c); | |
| 60 EXPECT_TRUE(ParseColor("501a", &c)); | |
| 61 EXPECT_EQ(SkColorSetARGB(0x55, 0x00, 0x11, 0xAA), c); | |
| 62 EXPECT_TRUE(ParseColor("01a", &c)); | |
| 63 EXPECT_EQ(SkColorSetRGB(0x00, 0x11, 0xAA), c); | |
| 64 EXPECT_TRUE(ParseColor("000000", &c)); | |
| 65 EXPECT_EQ(SkColorSetARGB(0xFF, 0x00, 0x00, 0x00), c); | |
| 66 EXPECT_TRUE(ParseColor("red", &c)); | |
| 67 EXPECT_EQ(SkColorSetARGB(0xFF, 0xFF, 0x00, 0x00), c); | |
| 68 } | |
| 69 | |
| 70 TEST_F(FallbackIconUrlParserTest, ParseColorFailure) { | |
| 71 const char* test_cases[] = { | |
| 72 "", | |
| 73 "00000", | |
| 74 "000000000", | |
| 75 " 000000", | |
| 76 "ABCDEFG", | |
| 77 "#000", | |
| 78 "#000000", | |
| 79 "000000 ", | |
| 80 "ABCDEFH", | |
| 81 "#ABCDEF", | |
| 82 }; | |
| 83 for (size_t i = 0; i < arraysize(test_cases); ++i) { | |
| 84 SkColor c; | |
| 85 EXPECT_FALSE(ParseColor(test_cases[i], &c)) | |
| 86 << "test_cases[" << i << "]"; | |
| 87 } | |
| 88 } | |
| 89 | |
| 90 TEST_F(FallbackIconUrlParserTest, ParseSpecsEmpty) { | |
| 91 int size; | |
| 92 FallbackIconStyle style; | |
| 93 EXPECT_TRUE(ParseSpecs(",,,,", &size, &style)); | |
| 94 EXPECT_EQ(16, size); | |
| 95 EXPECT_EQ(kDefaultBackgroundColor, style.background_color); | |
| 96 EXPECT_TRUE(style.is_default_background_color); | |
| 97 EXPECT_EQ(kDefaultTextColorLight, style.text_color); | |
| 98 EXPECT_EQ(kDefaultFontSizeRatio, style.font_size_ratio); | |
| 99 EXPECT_EQ(kDefaultRoundness, style.roundness); | |
| 100 } | |
| 101 | |
| 102 TEST_F(FallbackIconUrlParserTest, ParseSpecsPartial) { | |
| 103 int size; | |
| 104 FallbackIconStyle style; | |
| 105 EXPECT_TRUE(ParseSpecs(",,aCE,,0.1", &size, &style)); | |
| 106 EXPECT_EQ(16, size); | |
| 107 EXPECT_EQ(kDefaultBackgroundColor, style.background_color); | |
| 108 EXPECT_TRUE(style.is_default_background_color); | |
| 109 EXPECT_EQ(SkColorSetRGB(0xAA, 0xCC, 0xEE), style.text_color); | |
| 110 EXPECT_EQ(kDefaultFontSizeRatio, style.font_size_ratio); | |
| 111 EXPECT_EQ(0.1, style.roundness); | |
| 112 } | |
| 113 | |
| 114 TEST_F(FallbackIconUrlParserTest, ParseSpecsFull) { | |
| 115 int size; | |
| 116 | |
| 117 { | |
| 118 FallbackIconStyle style; | |
| 119 EXPECT_TRUE(ParseSpecs("16,000,f01,0.75,0.25", &size, &style)); | |
| 120 EXPECT_EQ(16, size); | |
| 121 EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color); | |
| 122 EXPECT_FALSE(style.is_default_background_color); | |
| 123 EXPECT_EQ(SkColorSetRGB(0xff, 0x00, 0x11), style.text_color); | |
| 124 EXPECT_EQ(0.75, style.font_size_ratio); | |
| 125 EXPECT_EQ(0.25, style.roundness); | |
| 126 } | |
| 127 | |
| 128 { | |
| 129 FallbackIconStyle style; | |
| 130 EXPECT_TRUE(ParseSpecs("48,black,123456,0.5,0.3", &size, &style)); | |
| 131 EXPECT_EQ(48, size); | |
| 132 EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color); | |
| 133 EXPECT_FALSE(style.is_default_background_color); | |
| 134 EXPECT_EQ(SkColorSetRGB(0x12, 0x34, 0x56), style.text_color); | |
| 135 EXPECT_EQ(0.5, style.font_size_ratio); | |
| 136 EXPECT_EQ(0.3, style.roundness); | |
| 137 } | |
| 138 | |
| 139 { | |
| 140 FallbackIconStyle style; | |
| 141 EXPECT_TRUE(ParseSpecs("1,000,red,0,0", &size, &style)); | |
| 142 EXPECT_EQ(1, size); | |
| 143 EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color); | |
| 144 EXPECT_FALSE(style.is_default_background_color); | |
| 145 EXPECT_EQ(SkColorSetRGB(0xFF, 0x00, 0x00), style.text_color); | |
| 146 EXPECT_EQ(0, style.font_size_ratio); | |
| 147 EXPECT_EQ(0, style.roundness); | |
| 148 } | |
| 149 } | |
| 150 | |
| 151 TEST_F(FallbackIconUrlParserTest, ParseSpecsDefaultTextColor) { | |
| 152 int size; | |
| 153 | |
| 154 { | |
| 155 // Dark background -> Light text. | |
| 156 FallbackIconStyle style; | |
| 157 EXPECT_TRUE(ParseSpecs(",000,,,", &size, &style)); | |
| 158 EXPECT_EQ(kDefaultTextColorLight, style.text_color); | |
| 159 } | |
| 160 | |
| 161 { | |
| 162 // Light background -> Dark text. | |
| 163 FallbackIconStyle style; | |
| 164 EXPECT_TRUE(ParseSpecs(",fff,,,", &size, &style)); | |
| 165 EXPECT_EQ(kDefaultTextColorDark, style.text_color); | |
| 166 } | |
| 167 | |
| 168 { | |
| 169 // Light background -> Dark text, more params don't matter. | |
| 170 FallbackIconStyle style; | |
| 171 EXPECT_TRUE(ParseSpecs("107,fff,,0.3,0.5", &size, &style)); | |
| 172 EXPECT_EQ(kDefaultTextColorDark, style.text_color); | |
| 173 } | |
| 174 } | |
| 175 | |
| 176 TEST_F(FallbackIconUrlParserTest, ParseSpecsFailure) { | |
| 177 const char* test_cases[] = { | |
| 178 // Need exactly 5 params. | |
| 179 "", | |
| 180 "16", | |
| 181 "16,black", | |
| 182 "16,black,fff", | |
| 183 "16,black,fff,0.75", | |
| 184 ",,," | |
| 185 ",,,,,", | |
| 186 "16,black,fff,0.75,0.25,junk", | |
| 187 // Don't allow any space. | |
| 188 "16,black,fff, 0.75,0.25", | |
| 189 "16,black ,fff,0.75,0.25", | |
| 190 "16,black,fff,0.75,0.25 ", | |
| 191 // Adding junk text. | |
| 192 "16,black,fff,0.75,0.25junk", | |
| 193 "junk,black,fff,0.75,0.25", | |
| 194 "16,#junk,fff,0.75,0.25", | |
| 195 "16,black,junk,0.75,0.25", | |
| 196 "16,black,fff,junk,0.25", | |
| 197 "16,black,fff,0.75,junk", | |
| 198 // Out of bound. | |
| 199 "0,black,fff,0.75,0.25", // size. | |
| 200 "4294967296,black,fff,0.75,0.25", // size. | |
| 201 "-1,black,fff,0.75,0.25", // size. | |
| 202 "16,black,fff,-0.1,0.25", // font_size_ratio. | |
| 203 "16,black,fff,1.1,0.25", // font_size_ratio. | |
| 204 "16,black,fff,0.75,-0.1", // roundness. | |
| 205 "16,black,fff,0.75,1.1", // roundness. | |
| 206 }; | |
| 207 for (size_t i = 0; i < arraysize(test_cases); ++i) { | |
| 208 int size; | |
| 209 FallbackIconStyle style; | |
| 210 EXPECT_FALSE(ParseSpecs(test_cases[i], &size, &style)) | |
| 211 << "test_cases[" << i << "]"; | |
| 212 | |
| 213 } | |
| 214 } | |
| 215 | |
| 216 TEST_F(FallbackIconUrlParserTest, ParseFallbackIconPathSuccess) { | |
| 217 const std::string specs = "31,black,fff,0.75,0.25"; | |
| 218 | |
| 219 // Everything populated. | |
| 220 { | |
| 221 chrome::ParsedFallbackIconPath parsed; | |
| 222 EXPECT_TRUE(parsed.Parse(specs + "/" + kTestUrlStr)); | |
| 223 EXPECT_EQ(31, parsed.size_in_pixels()); | |
| 224 const favicon_base::FallbackIconStyle& style = parsed.style(); | |
| 225 EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color); | |
| 226 EXPECT_FALSE(style.is_default_background_color); | |
| 227 EXPECT_EQ(SkColorSetRGB(0xFF, 0xFF, 0xFF), style.text_color); | |
| 228 EXPECT_EQ(0.75, style.font_size_ratio); | |
| 229 EXPECT_EQ(0.25, style.roundness); | |
| 230 EXPECT_EQ(GURL(kTestUrlStr), GURL(parsed.url_string())); | |
| 231 EXPECT_EQ(specs.length() + 1, parsed.path_index()); | |
| 232 } | |
| 233 | |
| 234 // Empty URL. | |
| 235 { | |
| 236 chrome::ParsedFallbackIconPath parsed; | |
| 237 EXPECT_TRUE(parsed.Parse(specs + "/")); | |
| 238 EXPECT_EQ(31, parsed.size_in_pixels()); | |
| 239 const favicon_base::FallbackIconStyle& style = parsed.style(); | |
| 240 EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color); | |
| 241 EXPECT_FALSE(style.is_default_background_color); | |
| 242 EXPECT_EQ(SkColorSetRGB(0xFF, 0xFF, 0xFF), style.text_color); | |
| 243 EXPECT_EQ(0.75, style.font_size_ratio); | |
| 244 EXPECT_EQ(0.25, style.roundness); | |
| 245 EXPECT_EQ(GURL(), GURL(parsed.url_string())); | |
| 246 EXPECT_EQ(specs.length() + 1, parsed.path_index()); | |
| 247 } | |
| 248 | |
| 249 // Tolerate invalid URL. | |
| 250 { | |
| 251 chrome::ParsedFallbackIconPath parsed; | |
| 252 EXPECT_TRUE(parsed.Parse(specs + "/NOT A VALID URL")); | |
| 253 EXPECT_EQ(31, parsed.size_in_pixels()); | |
| 254 const favicon_base::FallbackIconStyle& style = parsed.style(); | |
| 255 EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color); | |
| 256 EXPECT_FALSE(style.is_default_background_color); | |
| 257 EXPECT_EQ(SkColorSetRGB(0xFF, 0xFF, 0xFF), style.text_color); | |
| 258 EXPECT_EQ(0.75, style.font_size_ratio); | |
| 259 EXPECT_EQ(0.25, style.roundness); | |
| 260 EXPECT_EQ("NOT A VALID URL", parsed.url_string()); | |
| 261 EXPECT_EQ(specs.length() + 1, parsed.path_index()); | |
| 262 } | |
| 263 | |
| 264 // Size and style are default. | |
| 265 { | |
| 266 std::string specs2 = ",,,,"; | |
| 267 chrome::ParsedFallbackIconPath parsed; | |
| 268 EXPECT_TRUE(parsed.Parse(specs2 + "/" + kTestUrlStr)); | |
| 269 EXPECT_EQ(gfx::kFaviconSize, parsed.size_in_pixels()); | |
| 270 const favicon_base::FallbackIconStyle& style = parsed.style(); | |
| 271 EXPECT_EQ(kDefaultBackgroundColor, style.background_color); | |
| 272 EXPECT_TRUE(style.is_default_background_color); | |
| 273 EXPECT_EQ(kDefaultTextColorLight, style.text_color); | |
| 274 EXPECT_EQ(kDefaultFontSizeRatio, style.font_size_ratio); | |
| 275 EXPECT_EQ(kDefaultRoundness, style.roundness); | |
| 276 EXPECT_EQ(GURL(kTestUrlStr), GURL(parsed.url_string())); | |
| 277 EXPECT_EQ(specs2.length() + 1, parsed.path_index()); | |
| 278 } | |
| 279 } | |
| 280 | |
| 281 TEST_F(FallbackIconUrlParserTest, ParseFallbackIconPathFailure) { | |
| 282 const char* test_cases[] = { | |
| 283 // Bad size. | |
| 284 "-1,000,fff,0.75,0.25/http://www.google.com/", | |
| 285 // Bad specs. | |
| 286 "32,#junk,fff,0.75,0.25/http://www.google.com/", | |
| 287 }; | |
| 288 for (size_t i = 0; i < arraysize(test_cases); ++i) { | |
| 289 chrome::ParsedFallbackIconPath parsed; | |
| 290 EXPECT_FALSE(parsed.Parse(test_cases[i])) << "test_cases[" << i << "]"; | |
| 291 } | |
| 292 } | |
| 293 | |
| 294 } // namespace chrome | |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 2883053003:
Delete unused chrome://fallback-icon/ handling (Closed)
