Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 2882853006: Move LocalFrameClientImpl to use WebLocalFrameBase instead of WebLocalFrameImpl. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
haraken, dcheng
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LocalFrameClientImpl to use WebLocalFrameBase instead of WebLocalFrameImpl. - Update all users of GetWebFrame() to use WebLocalFrameBase. - Make methods declared only in WebLocalFrameImpl pure virtual in WebLocalFrameBase and override the methods in WebLocalFrameImpl. BUG=708879 Review-Url: https://codereview.chromium.org/2882853006 Cr-Commit-Position: refs/heads/master@{#472685} Committed: https://chromium.googlesource.com/chromium/src/+/b7c38bba708dbb4156b197acb2b44676052d0599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -37 lines) Patch
M third_party/WebKit/Source/core/frame/WebLocalFrameBase.h View 2 chunks +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsFrontendImpl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 7 chunks +16 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (12 generated)
slangley
3 years, 7 months ago (2017-05-16 01:33:56 UTC) #4
haraken
LGTM
3 years, 7 months ago (2017-05-16 02:35:53 UTC) #5
dcheng
LGTM
3 years, 7 months ago (2017-05-16 03:52:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882853006/1
3 years, 7 months ago (2017-05-17 11:09:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457212)
3 years, 7 months ago (2017-05-17 12:50:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882853006/1
3 years, 7 months ago (2017-05-17 20:55:26 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/458175)
3 years, 7 months ago (2017-05-18 00:50:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882853006/1
3 years, 7 months ago (2017-05-18 00:52:44 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/458468)
3 years, 7 months ago (2017-05-18 03:46:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882853006/1
3 years, 7 months ago (2017-05-18 03:50:28 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 05:38:12 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b7c38bba708dbb4156b197acb2b4...

Powered by Google App Engine
This is Rietveld 408576698