Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2884563003: Move WebFrameWidgetBase to core/frame/. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
haraken, dcheng
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, kinuko+watch, mac-reviews_chromium.org, mlamouri+watch-blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebFrameWidgetBase to core/frame/. - Update include paths in classes that are using WebFrameViewWidgetBase. - Provide covariant overload of FrameWidget() in WebLocalFrameBase. BUG=708879 Review-Url: https://codereview.chromium.org/2884563003 Cr-Commit-Position: refs/heads/master@{#472077} Committed: https://chromium.googlesource.com/chromium/src/+/7c40d5119d9f765bf455f4b42d003fd4d5e3564f

Patch Set 1 #

Patch Set 2 : Define FrameWidget() in WebLocalFrameBase and override in WebLocalFrameImpl. #

Patch Set 3 : Fix windows build error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -428 lines) Patch
M third_party/WebKit/Source/core/frame/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/frame/WebFrameWidgetBase.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/WebLocalFrameBase.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/web/WebFrameWidgetBase.h View 1 chunk +0 lines, -133 lines 0 comments Download
D third_party/WebKit/Source/web/WebFrameWidgetBase.cpp View 1 chunk +0 lines, -287 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/mac/WebSubstringUtil.mm View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (16 generated)
slangley
3 years, 7 months ago (2017-05-15 10:54:31 UTC) #5
dcheng
LGTM (I think we might want this in platform event eventually, but that's out of ...
3 years, 7 months ago (2017-05-15 11:01:36 UTC) #6
dcheng
On 2017/05/15 11:01:36, dcheng (in AEST) wrote: > LGTM > > (I think we might ...
3 years, 7 months ago (2017-05-15 11:02:02 UTC) #7
haraken
LGTM
3 years, 7 months ago (2017-05-15 16:11:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884563003/20001
3 years, 7 months ago (2017-05-15 23:55:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/411853)
3 years, 7 months ago (2017-05-16 01:44:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884563003/40001
3 years, 7 months ago (2017-05-16 04:02:41 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/445429)
3 years, 7 months ago (2017-05-16 05:48:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884563003/40001
3 years, 7 months ago (2017-05-16 06:41:00 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/455577)
3 years, 7 months ago (2017-05-16 08:26:10 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884563003/40001
3 years, 7 months ago (2017-05-16 10:17:47 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/455677)
3 years, 7 months ago (2017-05-16 11:45:44 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884563003/40001
3 years, 7 months ago (2017-05-16 11:48:43 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 13:23:53 UTC) #30
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7c40d5119d9f765bf455f4b42d00...

Powered by Google App Engine
This is Rietveld 408576698