Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: third_party/WebKit/Source/core/frame/WebLocalFrameBase.h

Issue 2882853006: Move LocalFrameClientImpl to use WebLocalFrameBase instead of WebLocalFrameImpl. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/LocalFrameClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
diff --git a/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h b/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
index 34c150d18936854e6fed3bdaeb597662a48210d4..ef7213c0142d28dcc52788eeb219adb314244798 100644
--- a/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
+++ b/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
@@ -7,22 +7,29 @@
#include "core/CoreExport.h"
#include "core/frame/WebFrameWidgetBase.h"
+#include "core/loader/FrameLoaderTypes.h"
#include "public/web/WebLocalFrame.h"
namespace blink {
+class ContentSettingsClient;
class FrameOwner;
class FrameView;
class LocalFrame;
class Node;
class Page;
+class SharedWorkerRepositoryClientImpl;
+class TextCheckerClient;
class TextFinder;
class WebDevToolsAgentImpl;
+class WebDevToolsFrontendImpl;
class WebFrameClient;
class WebFrameWidgetBase;
class WebTextCheckClient;
class WebViewBase;
+struct FrameLoadRequest;
+
// WebLocalFrameBase is a temporary class the provides a layer of abstraction
// for WebLocalFrameImpl. Mehtods that are declared public in WebLocalFrameImpl
// that are not overrides from WebLocalFrame will be declared pure virtual in
@@ -52,6 +59,23 @@ class WebLocalFrameBase : public GarbageCollectedFinalized<WebLocalFrameBase>,
virtual WebFrameWidgetBase* FrameWidget() const = 0;
virtual void SetFrameWidget(WebFrameWidgetBase*) = 0;
virtual WebDevToolsAgentImpl* DevToolsAgentImpl() const = 0;
+ virtual void SetDevToolsFrontend(WebDevToolsFrontendImpl*) = 0;
+ virtual WebDevToolsFrontendImpl* DevToolsFrontend() = 0;
+ virtual void WillBeDetached() = 0;
+ virtual void WillDetachParent() = 0;
+ virtual void SetCoreFrame(LocalFrame*) = 0;
+ virtual void DidFail(const ResourceError&,
+ bool was_provisional,
+ HistoryCommitType) = 0;
+ virtual void DidFinish() = 0;
+ virtual void CreateFrameView() = 0;
+ virtual LocalFrame* CreateChildFrame(const FrameLoadRequest&,
+ const AtomicString& name,
+ HTMLFrameOwnerElement*) = 0;
+ virtual ContentSettingsClient& GetContentSettingsClient() = 0;
+ virtual SharedWorkerRepositoryClientImpl* SharedWorkerRepositoryClient()
+ const = 0;
+ virtual TextCheckerClient& GetTextCheckerClient() const = 0;
DEFINE_INLINE_VIRTUAL_TRACE() {}
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/LocalFrameClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698