Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: third_party/WebKit/Source/core/frame/WebLocalFrameBase.h

Issue 2882853006: Move LocalFrameClientImpl to use WebLocalFrameBase instead of WebLocalFrameImpl. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/LocalFrameClientImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.#ifndef WebViewBase_h 3 // found in the LICENSE file.#ifndef WebViewBase_h
4 4
5 #ifndef WebLocalFrameBase_h 5 #ifndef WebLocalFrameBase_h
6 #define WebLocalFrameBase_h 6 #define WebLocalFrameBase_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/frame/WebFrameWidgetBase.h" 9 #include "core/frame/WebFrameWidgetBase.h"
10 #include "core/loader/FrameLoaderTypes.h"
10 #include "public/web/WebLocalFrame.h" 11 #include "public/web/WebLocalFrame.h"
11 12
12 namespace blink { 13 namespace blink {
13 14
15 class ContentSettingsClient;
14 class FrameOwner; 16 class FrameOwner;
15 class FrameView; 17 class FrameView;
16 class LocalFrame; 18 class LocalFrame;
17 class Node; 19 class Node;
18 class Page; 20 class Page;
21 class SharedWorkerRepositoryClientImpl;
22 class TextCheckerClient;
19 class TextFinder; 23 class TextFinder;
20 class WebDevToolsAgentImpl; 24 class WebDevToolsAgentImpl;
25 class WebDevToolsFrontendImpl;
21 class WebFrameClient; 26 class WebFrameClient;
22 class WebFrameWidgetBase; 27 class WebFrameWidgetBase;
23 class WebTextCheckClient; 28 class WebTextCheckClient;
24 class WebViewBase; 29 class WebViewBase;
25 30
31 struct FrameLoadRequest;
32
26 // WebLocalFrameBase is a temporary class the provides a layer of abstraction 33 // WebLocalFrameBase is a temporary class the provides a layer of abstraction
27 // for WebLocalFrameImpl. Mehtods that are declared public in WebLocalFrameImpl 34 // for WebLocalFrameImpl. Mehtods that are declared public in WebLocalFrameImpl
28 // that are not overrides from WebLocalFrame will be declared pure virtual in 35 // that are not overrides from WebLocalFrame will be declared pure virtual in
29 // WebLocalFrameBase. Classes that then have a dependency on WebLocalFrameImpl 36 // WebLocalFrameBase. Classes that then have a dependency on WebLocalFrameImpl
30 // will then take a dependency on WebLocalFrameBase instead, so we can remove 37 // will then take a dependency on WebLocalFrameBase instead, so we can remove
31 // cyclic dependencies in web/ and move classes from web/ into core/ or 38 // cyclic dependencies in web/ and move classes from web/ into core/ or
32 // modules. 39 // modules.
33 // TODO(slangley): Remove this class once WebLocalFrameImpl is in core/. 40 // TODO(slangley): Remove this class once WebLocalFrameImpl is in core/.
34 class WebLocalFrameBase : public GarbageCollectedFinalized<WebLocalFrameBase>, 41 class WebLocalFrameBase : public GarbageCollectedFinalized<WebLocalFrameBase>,
35 public WebLocalFrame { 42 public WebLocalFrame {
36 public: 43 public:
37 CORE_EXPORT static WebLocalFrameBase* FromFrame(LocalFrame*); 44 CORE_EXPORT static WebLocalFrameBase* FromFrame(LocalFrame*);
38 CORE_EXPORT static WebLocalFrameBase* FromFrame(LocalFrame&); 45 CORE_EXPORT static WebLocalFrameBase* FromFrame(LocalFrame&);
39 46
40 virtual WebViewBase* ViewImpl() const = 0; 47 virtual WebViewBase* ViewImpl() const = 0;
41 virtual WebFrameClient* Client() const = 0; 48 virtual WebFrameClient* Client() const = 0;
42 virtual void SetClient(WebFrameClient*) = 0; 49 virtual void SetClient(WebFrameClient*) = 0;
43 virtual WebTextCheckClient* TextCheckClient() const = 0; 50 virtual WebTextCheckClient* TextCheckClient() const = 0;
44 virtual void SetContextMenuNode(Node*) = 0; 51 virtual void SetContextMenuNode(Node*) = 0;
45 virtual void ClearContextMenuNode() = 0; 52 virtual void ClearContextMenuNode() = 0;
46 virtual LocalFrame* GetFrame() const = 0; 53 virtual LocalFrame* GetFrame() const = 0;
47 virtual FrameView* GetFrameView() const = 0; 54 virtual FrameView* GetFrameView() const = 0;
48 virtual void InitializeCoreFrame(Page&, 55 virtual void InitializeCoreFrame(Page&,
49 FrameOwner*, 56 FrameOwner*,
50 const AtomicString& name) = 0; 57 const AtomicString& name) = 0;
51 virtual TextFinder& EnsureTextFinder() = 0; 58 virtual TextFinder& EnsureTextFinder() = 0;
52 virtual WebFrameWidgetBase* FrameWidget() const = 0; 59 virtual WebFrameWidgetBase* FrameWidget() const = 0;
53 virtual void SetFrameWidget(WebFrameWidgetBase*) = 0; 60 virtual void SetFrameWidget(WebFrameWidgetBase*) = 0;
54 virtual WebDevToolsAgentImpl* DevToolsAgentImpl() const = 0; 61 virtual WebDevToolsAgentImpl* DevToolsAgentImpl() const = 0;
62 virtual void SetDevToolsFrontend(WebDevToolsFrontendImpl*) = 0;
63 virtual WebDevToolsFrontendImpl* DevToolsFrontend() = 0;
64 virtual void WillBeDetached() = 0;
65 virtual void WillDetachParent() = 0;
66 virtual void SetCoreFrame(LocalFrame*) = 0;
67 virtual void DidFail(const ResourceError&,
68 bool was_provisional,
69 HistoryCommitType) = 0;
70 virtual void DidFinish() = 0;
71 virtual void CreateFrameView() = 0;
72 virtual LocalFrame* CreateChildFrame(const FrameLoadRequest&,
73 const AtomicString& name,
74 HTMLFrameOwnerElement*) = 0;
75 virtual ContentSettingsClient& GetContentSettingsClient() = 0;
76 virtual SharedWorkerRepositoryClientImpl* SharedWorkerRepositoryClient()
77 const = 0;
78 virtual TextCheckerClient& GetTextCheckerClient() const = 0;
55 79
56 DEFINE_INLINE_VIRTUAL_TRACE() {} 80 DEFINE_INLINE_VIRTUAL_TRACE() {}
57 81
58 protected: 82 protected:
59 explicit WebLocalFrameBase(WebTreeScopeType scope) : WebLocalFrame(scope) {} 83 explicit WebLocalFrameBase(WebTreeScopeType scope) : WebLocalFrame(scope) {}
60 }; 84 };
61 85
62 DEFINE_TYPE_CASTS(WebLocalFrameBase, 86 DEFINE_TYPE_CASTS(WebLocalFrameBase,
63 WebFrame, 87 WebFrame,
64 frame, 88 frame,
65 frame->IsWebLocalFrame(), 89 frame->IsWebLocalFrame(),
66 frame.IsWebLocalFrame()); 90 frame.IsWebLocalFrame());
67 91
68 } // namespace blink 92 } // namespace blink
69 93
70 #endif // WebLocalFrameBase_h 94 #endif // WebLocalFrameBase_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/LocalFrameClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698