[CRD iOS] Injecting scroll events w/ fling animation

[CRD iOS] Injecting scroll events w/ fling animation

This CL adds two-finger scrolling support with fling animation to the CRD iOS
client.

BUG=718704
Review-Url: https://codereview.chromium.org/2882653004
Cr-Commit-Position: refs/heads/master@{#472353}
Committed: https://chromium.googlesource.com/chromium/src/+/f6db64d1daaeeb654e6fde7badf189bd82821ae8

[Yuwei, 2017-05-16 01:03:22]

Description was changed from

==========
[CRD iOS] Injecting scroll events w/ fling animation
==========

to

==========
[CRD iOS] Injecting scroll events w/ fling animation

This CL adds two-finger scrolling support with fling animation to the CRD iOS
client.

BUG=718704
==========

[Yuwei, 2017-05-16 01:05:54]

yuweih@chromium.org changed reviewers:
+ nicholss@chromium.org

[Yuwei, 2017-05-16 01:05:54]

PTAL thanks!

Note that this is a dependent CL on CL 2879743002 which does some refactoring
work on the InputStrategy. This is to give you an early look before we make
decisions about the refactoring work.

[nicholss, 2017-05-16 18:13:11]

LGTM, some minor comments around function names and a guard update. Good job!

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/dire...
File remoting/client/ui/direct_input_strategy.h (right):

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/dire...
remoting/client/ui/direct_input_strategy.h:5: #ifndef
REMOTING_CLIENT_UI_SIMULATED_TOUCH_INPUT_STRATEGY_H_
Looks like the guard needs to be updated

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/gest...
File remoting/client/ui/gesture_interpreter.cc (right):

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/gest...
remoting/client/ui/gesture_interpreter.cc:120: if
(scroll_animation_.IsAnimationInProgress()) {
Does it hurt to call Tick without checking IsAnimationInProgress externally and
instead check internally to the class? What is the side effect of calling tick
with no animation happening?

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/gest...
File remoting/client/ui/gesture_interpreter.h (right):

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/gest...
remoting/client/ui/gesture_interpreter.h:54: void ScrollFling(float velocity_x,
float velocity_y);
Fling does not mean a ton, perhaps just ScollWithVelocity?

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/inpu...
File remoting/client/ui/input_strategy.h (right):

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/inpu...
remoting/client/ui/input_strategy.h:52: virtual ViewMatrix::Vector2D
MapScrollVector(
I would expect this function to be MapXtoY style. Ie:
MapInputVectorToScrollVector  or something like this?

[Yuwei, 2017-05-16 22:08:51]

The CQ bit was checked by yuweih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 22:10:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:43:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:43:18]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Yuwei, 2017-05-17 05:42:20]

Thanks!

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/dire...
File remoting/client/ui/direct_input_strategy.h (right):

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/dire...
remoting/client/ui/direct_input_strategy.h:5: #ifndef
REMOTING_CLIENT_UI_SIMULATED_TOUCH_INPUT_STRATEGY_H_
On 2017/05/16 18:13:10, nicholss wrote:
> Looks like the guard needs to be updated

Oops! Done

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/gest...
File remoting/client/ui/gesture_interpreter.cc (right):

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/gest...
remoting/client/ui/gesture_interpreter.cc:120: if
(scroll_animation_.IsAnimationInProgress()) {
On 2017/05/16 18:13:10, nicholss wrote:
> Does it hurt to call Tick without checking IsAnimationInProgress externally
and
> instead check internally to the class? What is the side effect of calling tick
> with no animation happening?

Done.

TBH nope. Just the negligible overhead of opening new stack frame O_o

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/gest...
File remoting/client/ui/gesture_interpreter.h (right):

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/gest...
remoting/client/ui/gesture_interpreter.h:54: void ScrollFling(float velocity_x,
float velocity_y);
On 2017/05/16 18:13:10, nicholss wrote:
> Fling does not mean a ton, perhaps just ScollWithVelocity?

Done.

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/inpu...
File remoting/client/ui/input_strategy.h (right):

https://codereview.chromium.org/2882653004/diff/40001/remoting/client/ui/inpu...
remoting/client/ui/input_strategy.h:52: virtual ViewMatrix::Vector2D
MapScrollVector(
On 2017/05/16 18:13:11, nicholss wrote:
> I would expect this function to be MapXtoY style. Ie:
> MapInputVectorToScrollVector  or something like this?

Done. Renamed to MapScreenVectorToDesktop

[Yuwei, 2017-05-17 05:42:25]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2017-05-17 05:42:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
nicholss@chromium.org
Link to the patchset: https://codereview.chromium.org/2882653004/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-17 05:43:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 06:34:37]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494999745582390,
"parent_rev": "4e5aa748d7b05a4057b1960585c3a5b5bc52561a", "commit_rev":
"f6db64d1daaeeb654e6fde7badf189bd82821ae8"}

[commit-bot: I haz the power, 2017-05-17 06:34:47]

Description was changed from

==========
[CRD iOS] Injecting scroll events w/ fling animation

This CL adds two-finger scrolling support with fling animation to the CRD iOS
client.

BUG=718704
==========

to

==========
[CRD iOS] Injecting scroll events w/ fling animation

This CL adds two-finger scrolling support with fling animation to the CRD iOS
client.

BUG=718704

Review-Url: https://codereview.chromium.org/2882653004
Cr-Commit-Position: refs/heads/master@{#472353}
Committed:
https://chromium.googlesource.com/chromium/src/+/f6db64d1daaeeb654e6fde7badf1...
==========

[commit-bot: I haz the power, 2017-05-17 06:34:48]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/f6db64d1daaeeb654e6fde7badf1...