Log the creation of several more dialog box types.

Log the creation of several more dialog box types.

BUG=705331
Review-Url: https://codereview.chromium.org/2881683002
Cr-Commit-Position: refs/heads/master@{#472604}
Committed: https://chromium.googlesource.com/chromium/src/+/7fa1d036e427d6a1fca97f8d954835d8d7220986

[pdyson, 2017-05-12 03:56:07]

The CQ bit was checked by pdyson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 03:56:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 04:11:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 04:11:12]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[pdyson, 2017-05-12 04:36:11]

The CQ bit was checked by pdyson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 04:36:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdyson, 2017-05-12 05:02:20]

pdyson@chromium.org changed reviewers:
+ jwd@chromium.org, msw@chromium.org

[commit-bot: I haz the power, 2017-05-12 05:44:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 05:44:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jwd, 2017-05-15 21:10:47]

lgtm

[msw, 2017-05-15 21:51:16]

https://codereview.chromium.org/2881683002/diff/40001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_dialogs.h (right):

https://codereview.chromium.org/2881683002/diff/40001/chrome/browser/ui/brows...
chrome/browser/ui/browser_dialogs.h:290: USER_MANAGER = 76,
I think this value is not used; perhaps you meant to only add
USER_MANAGER_PROFILE?

https://codereview.chromium.org/2881683002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/enums.xml (right):

https://codereview.chromium.org/2881683002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/enums.xml:7263: +  <int value="70" label="Ssl Client
Certificate Selector"/>
nit: capitalize SSL?

[pdyson, 2017-05-16 01:03:42]

The CQ bit was checked by pdyson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 01:04:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdyson, 2017-05-16 01:06:47]

Now logging USER_MANAGER.

Also, swapped the order of USER_MANAGER_PROFILE and USER_MANAGER as they were
out of alphabetical order. Also swapped JAVA_SCRIPT_APP_MODAL_X11 and
JAVA_SCRIPT for the same reason.

https://codereview.chromium.org/2881683002/diff/40001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_dialogs.h (right):

https://codereview.chromium.org/2881683002/diff/40001/chrome/browser/ui/brows...
chrome/browser/ui/browser_dialogs.h:290: USER_MANAGER = 76,
On 2017/05/15 at 21:51:15, msw wrote:
> I think this value is not used; perhaps you meant to only add
USER_MANAGER_PROFILE?

Good catch. I've now added the logging for USER_MANAGER. I missed it as there
were two classes to log in the file user_manager_view.cc.

https://codereview.chromium.org/2881683002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/enums.xml (right):

https://codereview.chromium.org/2881683002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/enums.xml:7263: +  <int value="70" label="Ssl Client
Certificate Selector"/>
On 2017/05/15 at 21:51:15, msw wrote:
> nit: capitalize SSL?

Done.

[commit-bot: I haz the power, 2017-05-16 02:07:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:07:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2017-05-16 17:29:43]

lgtm. Please try to split out rebase patchsets in the future.

[pdyson, 2017-05-16 23:10:36]

The CQ bit was checked by pdyson@chromium.org

[pdyson, 2017-05-16 23:10:37]

The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2881683002/#ps80001
(title: "Fix alphabetization errors.")

[commit-bot: I haz the power, 2017-05-16 23:12:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:47:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:47:54]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pdyson, 2017-05-17 00:18:34]

pdyson@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2017-05-17 17:17:29]

c/b/chromeos owner lgtm

[pdyson, 2017-05-17 21:30:18]

The CQ bit was checked by pdyson@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:31:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 23:54:49]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495056618803070,
"parent_rev": "3500da4e1d21348bf5f93b022842364b8902b4e0", "commit_rev":
"7fa1d036e427d6a1fca97f8d954835d8d7220986"}

[commit-bot: I haz the power, 2017-05-17 23:55:05]

Description was changed from

==========
Log the creation of several more dialog box types.

BUG=705331
==========

to

==========
Log the creation of several more dialog box types.

BUG=705331

Review-Url: https://codereview.chromium.org/2881683002
Cr-Commit-Position: refs/heads/master@{#472604}
Committed:
https://chromium.googlesource.com/chromium/src/+/7fa1d036e427d6a1fca97f8d9548...
==========

[commit-bot: I haz the power, 2017-05-17 23:55:07]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7fa1d036e427d6a1fca97f8d9548...