Log the creation of several more dialog box types.

chrome/browser/ui/browser_dialogs.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
 #define CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 225 matching lines @@
   EXTENSION_UNINSTALL = 22,
   EXTENSION_INSTALLED = 23,
   PAYMENT_REQUEST = 24,
   SAVE_CARD = 25,
   CARD_UNMASK = 26,
   SIGN_IN = 27,
   SIGN_IN_SYNC_CONFIRMATION = 28,
   SIGN_IN_ERROR = 29,
   SIGN_IN_EMAIL_CONFIRMATION = 30,
   PROFILE_CHOOSER = 31,
+  ACCOUNT_CHOOSER = 32,
+  ARC_APP = 33,
+  AUTO_SIGNIN_FIRST_RUN = 34,
+  BOOKMARK_APP_CONFIRMATION = 35,
+  CHOOSER_UI = 36,
+  CHOOSER = 37,
+  COLLECTED_COOKIES = 38,
+  CONSTRAINED_WEB = 39,
+  CONTENT_SETTING_CONTENTS = 40,
+  CREATE_CHROME_APPLICATION_SHORTCUT = 41,
+  DOWNLOAD_DANGER_PROMPT = 42,
+  DOWNLOAD_IN_PROGRESS = 43,
+  ECHO = 44,
+  ENROLLMENT = 45,
+  EXTENSION = 46,
+  EXTENSION_POPUP_AURA = 47,
+  EXTERNAL_PROTOCOL = 48,
+  EXTERNAL_PROTOCOL_CHROMEOS = 49,
+  FIRST_RUN_DIALOG = 50,
+  HOME_PAGE_UNDO = 51,
+  IDLE_ACTION_WARNING = 52,
+  IMPORT_LOCK = 53,
+  INTENT_PICKER = 54,
+  INVERT = 55,
+  JAVA_SCRIPT_APP_MODAL_X11 = 56,
+  JAVA_SCRIPT = 57,
+  LOGIN_HANDLER = 58,
+  MANAGE_PASSWORDS = 59,
+  MEDIA_GALLERIES = 60,
+  MULTIPROFILES_INTRO = 61,
+  MULTIPROFILES_SESSION_ABORTED = 62,
+  NATIVE_CONTAINER = 63,
+  NETWORK_CONFIG = 64,
+  PERMISSIONS = 65,
+  PLATFORM_KEYS_CERTIFICATE_SELECTOR = 66,
+  PLATFORM_VERIFICATION = 67,
+  PROXIMITY_AUTH_ERROR = 68,
+  REQUEST_PIN = 69,
+  SSL_CLIENT_CERTIFICATE_SELECTOR = 70,
+  SIMPLE_MESSAGE_BOX = 71,
+  TAB_MODAL_CONFIRM = 72,
+  TASK_MANAGER = 73,
+  TELEPORT_WARNING = 74,
+  USER_MANAGER_PROFILE = 75,
+  USER_MANAGER = 76,

[msw, 2017/05/15 21:51:15]

I think this value is not used; perhaps you meant to only add
USER_MANAGER_PROFILE?

[pdyson, 2017/05/16 01:06:46]

Good catch. I've now added the logging for USER_MANAGER. I missed it as there
were two classes to log in the file user_manager_view.cc.

+  VALIDATION_MESSAGE = 77,
+  WEB_SHARE_TARGET_PICKER = 78,
+  ZOOM = 79,
   MAX_VALUE
 };
 
 // Record an UMA metric counting the creation of a dialog box of this type.
 void RecordDialogCreation(DialogIdentifier identifier);
 
 #if defined(OS_WIN)
 
 // Shows the Chrome Cleanup dialog asking the user if they want to clean their
 // system from unwanted software. This is called when unwanted software has been
@@ skipping 21 matching lines @@
 using BubbleShowPtr =
     void (*)(content::WebContents*,
              const std::vector<arc::ArcNavigationThrottle::AppInfo>&,
              const IntentPickerResponse&);
 
 BubbleShowPtr ShowIntentPickerBubble();
 
 #endif  // OS_CHROMEOS
 
 #endif  // CHROME_BROWSER_UI_BROWSER_DIALOGS_H_