Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: chrome/browser/ui/views/arc_app_dialog_view.cc

Issue 2881683002: Log the creation of several more dialog box types. (Closed)
Patch Set: Fix alphabetization errors. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/app_list/arc/arc_app_dialog.h" 5 #include "chrome/browser/ui/app_list/arc/arc_app_dialog.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/extensions/extension_util.h" 10 #include "chrome/browser/extensions/extension_util.h"
11 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/browser/ui/app_list/app_list_controller_delegate.h" 12 #include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
13 #include "chrome/browser/ui/app_list/arc/arc_app_icon_loader.h" 13 #include "chrome/browser/ui/app_list/arc/arc_app_icon_loader.h"
14 #include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h" 14 #include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"
15 #include "chrome/browser/ui/app_list/arc/arc_app_utils.h" 15 #include "chrome/browser/ui/app_list/arc/arc_app_utils.h"
16 #include "chrome/browser/ui/browser_dialogs.h"
16 #include "chrome/browser/ui/native_window_tracker.h" 17 #include "chrome/browser/ui/native_window_tracker.h"
17 #include "chrome/browser/ui/views/harmony/chrome_layout_provider.h" 18 #include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"
18 #include "chrome/grit/generated_resources.h" 19 #include "chrome/grit/generated_resources.h"
19 #include "components/constrained_window/constrained_window_views.h" 20 #include "components/constrained_window/constrained_window_views.h"
20 #include "components/strings/grit/components_strings.h" 21 #include "components/strings/grit/components_strings.h"
21 #include "ui/base/l10n/l10n_util.h" 22 #include "ui/base/l10n/l10n_util.h"
22 #include "ui/base/ui_base_types.h" 23 #include "ui/base/ui_base_types.h"
23 #include "ui/views/controls/image_view.h" 24 #include "ui/views/controls/image_view.h"
24 #include "ui/views/controls/label.h" 25 #include "ui/views/controls/label.h"
25 #include "ui/views/layout/box_layout.h" 26 #include "ui/views/layout/box_layout.h"
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 162
162 AddChildView(text_container); 163 AddChildView(text_container);
163 DCHECK(!heading_text.empty()); 164 DCHECK(!heading_text.empty());
164 AddMultiLineLabel(text_container, heading_text); 165 AddMultiLineLabel(text_container, heading_text);
165 if (!subheading_text.empty()) 166 if (!subheading_text.empty())
166 AddMultiLineLabel(text_container, subheading_text); 167 AddMultiLineLabel(text_container, subheading_text);
167 168
168 icon_loader_.reset(new ArcAppIconLoader(profile_, kIconSourceSize, this)); 169 icon_loader_.reset(new ArcAppIconLoader(profile_, kIconSourceSize, this));
169 // The dialog will show once the icon is loaded. 170 // The dialog will show once the icon is loaded.
170 icon_loader_->FetchImage(app_id_); 171 icon_loader_->FetchImage(app_id_);
172 chrome::RecordDialogCreation(chrome::DialogIdentifier::ARC_APP);
171 } 173 }
172 174
173 ArcAppDialogView::~ArcAppDialogView() { 175 ArcAppDialogView::~ArcAppDialogView() {
174 DCHECK_EQ(this, g_current_arc_app_dialog_view); 176 DCHECK_EQ(this, g_current_arc_app_dialog_view);
175 g_current_arc_app_dialog_view = nullptr; 177 g_current_arc_app_dialog_view = nullptr;
176 } 178 }
177 179
178 void ArcAppDialogView::AddMultiLineLabel(views::View* parent, 180 void ArcAppDialogView::AddMultiLineLabel(views::View* parent,
179 const base::string16& label_text) { 181 const base::string16& label_text) {
180 views::Label* label = new views::Label(label_text); 182 views::Label* label = new views::Label(label_text);
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 296
295 bool CloseAppDialogViewAndConfirmForTest(bool confirm) { 297 bool CloseAppDialogViewAndConfirmForTest(bool confirm) {
296 if (!g_current_arc_app_dialog_view) 298 if (!g_current_arc_app_dialog_view)
297 return false; 299 return false;
298 300
299 g_current_arc_app_dialog_view->ConfirmOrCancelForTest(confirm); 301 g_current_arc_app_dialog_view->ConfirmOrCancelForTest(confirm);
300 return true; 302 return true;
301 } 303 }
302 304
303 } // namespace arc 305 } // namespace arc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698