chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc - Issue 2881683002: Log the creation of several more dialog box types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc

Issue 2881683002: Log the creation of several more dialog box types. (Closed)

Patch Set: Fix alphabetization errors. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/download/download_in_progress_dialog_view.cc ('k') | chrome/browser/ui/views/extensions/chooser_dialog_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc

diff --git a/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc b/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc

index e1e5aeb24b34c3cb8ce4135f977eca59ab219b1c..f9df93a40bad1cec85a23f86e29668639419c6ea 100644

--- a/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc

+++ b/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc

@@ -8,6 +8,7 @@

#include "base/strings/string16.h"

#include "base/strings/string_util.h"

#include "build/build_config.h"

+#include "chrome/browser/ui/browser_dialogs.h"

#include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"

#include "chrome/grit/generated_resources.h"

#include "components/constrained_window/constrained_window_views.h"

@@ -116,6 +117,8 @@ BookmarkAppConfirmationView::BookmarkAppConfirmationView(

layout->AddView(open_as_window_checkbox_);

title_tf_->SelectAll(true);

+ chrome::RecordDialogCreation(

+ chrome::DialogIdentifier::BOOKMARK_APP_CONFIRMATION);

}

views::View* BookmarkAppConfirmationView::GetInitiallyFocusedView() {