Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Issue 288153004: SyncPointManager never returns 0. (Closed)

Created:
6 years, 7 months ago by dshwang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

SyncPointManager never returns 0. When the next sync point overflow occurs, it returns 1, not 0. BUG=365904, 373452 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270997

Patch Set 1 #

Patch Set 2 : rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/common/gpu/sync_point_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/sync_point_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
dshwang
It's follow-up CL of https://codereview.chromium.org/279303003 Could you review?
6 years, 7 months ago (2014-05-15 09:08:38 UTC) #1
dshwang
We've concerned about sync point overflow, but we've ignored because it might take several years. ...
6 years, 7 months ago (2014-05-15 09:12:04 UTC) #2
piman
lgtm
6 years, 7 months ago (2014-05-15 17:07:37 UTC) #3
jbauman
lgtm
6 years, 7 months ago (2014-05-15 23:18:08 UTC) #4
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 7 months ago (2014-05-16 07:31:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/288153004/1
6 years, 7 months ago (2014-05-16 07:32:38 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 08:43:20 UTC) #7
commit-bot: I haz the power
Failed to apply patch for @master/content/common/gpu/sync_point_manager.cc: While running svn add @master --force --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive; ...
6 years, 7 months ago (2014-05-16 08:43:21 UTC) #8
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 7 months ago (2014-05-16 09:28:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/288153004/20001
6 years, 7 months ago (2014-05-16 09:29:24 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 11:15:07 UTC) #11
commit-bot: I haz the power
Failed to apply patch for @master/content/common/gpu/sync_point_manager.cc: While running svn add @master --force --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive; ...
6 years, 7 months ago (2014-05-16 11:15:08 UTC) #12
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 7 months ago (2014-05-16 11:48:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/288153004/20001
6 years, 7 months ago (2014-05-16 11:49:15 UTC) #14
commit-bot: I haz the power
Change committed as 270997
6 years, 7 months ago (2014-05-16 11:57:59 UTC) #15
no sievers
Mind changing this also in in_process_command_buffer.cc in the SyncPointManager class there (for tests)?
6 years, 7 months ago (2014-05-16 16:59:01 UTC) #16
dshwang
6 years, 7 months ago (2014-05-16 17:52:52 UTC) #17
Message was sent while issue was closed.
On 2014/05/16 16:59:01, sievers wrote:
> Mind changing this also in in_process_command_buffer.cc in the
SyncPointManager
> class there (for tests)?

I don't fully understand your question. Could you repeat the question?
By the way, in_process_command_buffer also uses sync_point_manager.
uint32 InProcessCommandBuffer::InsertSyncPoint() {
  uint32 sync_point = g_sync_point_manager.Get().GenerateSyncPoint();
  QueueTask(base::Bind(&InProcessCommandBuffer::RetireSyncPointOnGpuThread,
                       base::Unretained(this),
                       sync_point));
  return sync_point;
}

Powered by Google App Engine
This is Rietveld 408576698