content/common/gpu/sync_point_manager.cc - Issue 288153004: SyncPointManager never returns 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/sync_point_manager.cc

Issue 288153004: SyncPointManager never returns 0. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase to ToT Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/sync_point_manager.cc

diff --git a/content/common/gpu/sync_point_manager.cc b/content/common/gpu/sync_point_manager.cc

index 9383574faf9eb1039d8111f0b8ff46389425335f..5aa4b7e8e8c51f07bee35cb715c046c1bf59f579 100644

--- a/content/common/gpu/sync_point_manager.cc

+++ b/content/common/gpu/sync_point_manager.cc

@@ -26,6 +26,9 @@ SyncPointManager::~SyncPointManager() {

uint32 SyncPointManager::GenerateSyncPoint() {

base::AutoLock lock(lock_);

uint32 sync_point = next_sync_point_++;

+ // When an integer overflow occurs, don't return 0.

+ if (!sync_point)

+ sync_point = next_sync_point_++;

// Note: wrapping would take days for a buggy/compromized renderer that would

// insert sync points in a loop, but if that were to happen, better explicitly

« no previous file with comments | « content/common/gpu/sync_point_manager.h ('k') | no next file » | no next file with comments »