Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 279303003: Randomize sync point starting number to reduce risk of GPU hangs. (Closed)

Created:
6 years, 7 months ago by jbauman
Modified:
6 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Randomize sync point starting number to reduce risk of GPU hangs. There's a race condition in sync point creation where code can start a wait on a sync point immediately before the sync point is inserted. This will cause the GPU channel to lock up, as the retire will be placed in the queue after the wait. This normally won't happen in practice (as the client should only wait on sync points that have been inserted) but it can happen if the GPU process restarts and the client waits on a sync point created by the old GPU process. To reduce the risk of this happening, randomize the starting sync point ID. That way it's much less likely that the sync point created by the old GPU process will soon be created in the new GPU process. BUG=365904, 373452 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270630

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M content/common/gpu/sync_point_manager.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
jbauman
6 years, 7 months ago (2014-05-14 18:06:36 UTC) #1
piman
https://codereview.chromium.org/279303003/diff/1/content/common/gpu/sync_point_manager.cc File content/common/gpu/sync_point_manager.cc (right): https://codereview.chromium.org/279303003/diff/1/content/common/gpu/sync_point_manager.cc#newcode12 content/common/gpu/sync_point_manager.cc:12: static const int kMaxSyncBase = 10000000; Because of the ...
6 years, 7 months ago (2014-05-14 19:21:29 UTC) #2
jbauman
On 2014/05/14 19:21:29, piman wrote: > https://codereview.chromium.org/279303003/diff/1/content/common/gpu/sync_point_manager.cc > File content/common/gpu/sync_point_manager.cc (right): > > https://codereview.chromium.org/279303003/diff/1/content/common/gpu/sync_point_manager.cc#newcode12 > ...
6 years, 7 months ago (2014-05-14 21:36:15 UTC) #3
piman
On 2014/05/14 21:36:15, jbauman wrote: > On 2014/05/14 19:21:29, piman wrote: > > > https://codereview.chromium.org/279303003/diff/1/content/common/gpu/sync_point_manager.cc ...
6 years, 7 months ago (2014-05-14 21:39:06 UTC) #4
piman
lgtm
6 years, 7 months ago (2014-05-14 21:39:23 UTC) #5
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 7 months ago (2014-05-14 21:40:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/279303003/20001
6 years, 7 months ago (2014-05-14 21:42:24 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 00:41:04 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 04:35:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/16182)
6 years, 7 months ago (2014-05-15 04:35:16 UTC) #10
Ken Russell (switch to Gerrit)
On 2014/05/15 04:35:16, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-05-15 05:41:12 UTC) #11
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 7 months ago (2014-05-15 06:29:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/279303003/20001
6 years, 7 months ago (2014-05-15 06:30:06 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 08:20:15 UTC) #14
Message was sent while issue was closed.
Change committed as 270630

Powered by Google App Engine
This is Rietveld 408576698