Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2881503002: Revert of build: Enable optimize_for_size unconditionally. (Closed)

Created:
3 years, 7 months ago by yhirano
Modified:
3 years, 7 months ago
Reviewers:
Nico, pcc1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of build: Enable optimize_for_size unconditionally. (patchset #1 id:1 of https://codereview.chromium.org/2864383003/ ) Reason for revert: Causes failures on a MSAN bot. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/440 Original issue's description: > build: Enable optimize_for_size unconditionally. > > This change causes us to favor size over speed on Linux and Mac, > which aligns the build config for those platforms with that of the > other supported platforms, and should reduce the binary size impact > of enabling ThinLTO. This change is expected to reduce binary size > for Linux official builds by about 15%. > > There may be unacceptable perf regressions associated with this > change, but the perf bots should at least let us know where those > regressions are. I plan to monitor the Linux and Mac perf bots once > it lands. > > BUG=660216 > R=thakis@chromium.org > > Review-Url: https://codereview.chromium.org/2864383003 > Cr-Commit-Position: refs/heads/master@{#470606} > Committed: https://chromium.googlesource.com/chromium/src/+/c1269ce7fec8568a1789e07b2b5bb3b630a67f5f TBR=thakis@chromium.org,pcc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=660216 Review-Url: https://codereview.chromium.org/2881503002 Cr-Commit-Position: refs/heads/master@{#470793} Committed: https://chromium.googlesource.com/chromium/src/+/2a6f440fa84a584d916254f9a4c4e4d83c53435f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
yhirano
Created Revert of build: Enable optimize_for_size unconditionally.
3 years, 7 months ago (2017-05-11 03:20:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881503002/1
3 years, 7 months ago (2017-05-11 03:22:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2a6f440fa84a584d916254f9a4c4e4d83c53435f
3 years, 7 months ago (2017-05-11 03:23:32 UTC) #6
pcc1
3 years, 7 months ago (2017-05-11 19:41:18 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2870393005/ by pcc@chromium.org.

The reason for reverting is: Relanding now that the msan issue is fixed:
https://codereview.chromium.org/2876693003.

Powered by Google App Engine
This is Rietveld 408576698