Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2881503002: Revert of build: Enable optimize_for_size unconditionally. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/compiler/compiler.gni") 8 import("//build/config/compiler/compiler.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 # The patch is preapplied to the internal toolchain and hence all bots. 67 # The patch is preapplied to the internal toolchain and hence all bots.
68 msvs_xtree_patched = false 68 msvs_xtree_patched = false
69 } 69 }
70 70
71 # Omit unwind support in official builds to save space. 71 # Omit unwind support in official builds to save space.
72 # We can use breakpad for these builds. 72 # We can use breakpad for these builds.
73 exclude_unwind_tables = (is_chrome_branded && is_official_build) || 73 exclude_unwind_tables = (is_chrome_branded && is_official_build) ||
74 (is_chromecast && !is_cast_desktop_build && !is_debug) 74 (is_chromecast && !is_cast_desktop_build && !is_debug)
75 75
76 # If true, optimize for size. Does not affect windows builds. 76 # If true, optimize for size. Does not affect windows builds.
77 optimize_for_size = true 77 # Linux & Mac favor speed over size.
78 # TODO(brettw) it's weird that Mac and desktop Linux are different. We should
79 # explore favoring size over speed in this case as well.
80 optimize_for_size = is_android || is_ios
78 81
79 # Enable fatal linker warnings. Building Chromium with certain versions 82 # Enable fatal linker warnings. Building Chromium with certain versions
80 # of binutils can cause linker warning. 83 # of binutils can cause linker warning.
81 # See: https://bugs.chromium.org/p/chromium/issues/detail?id=457359 84 # See: https://bugs.chromium.org/p/chromium/issues/detail?id=457359
82 fatal_linker_warnings = true 85 fatal_linker_warnings = true
83 86
84 # Build with C++ RTTI enabled. Chromium builds without RTTI by default, 87 # Build with C++ RTTI enabled. Chromium builds without RTTI by default,
85 # but some sanitizers are known to require it, like CFI diagnostics 88 # but some sanitizers are known to require it, like CFI diagnostics
86 # and UBsan variants. 89 # and UBsan variants.
87 use_rtti = use_cfi_diag || is_ubsan_vptr || is_ubsan_security 90 use_rtti = use_cfi_diag || is_ubsan_vptr || is_ubsan_security
(...skipping 1662 matching lines...) Expand 10 before | Expand all | Expand 10 after
1750 1753
1751 if (is_ios || is_mac) { 1754 if (is_ios || is_mac) {
1752 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1755 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1753 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1756 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1754 config("enable_arc") { 1757 config("enable_arc") {
1755 common_flags = [ "-fobjc-arc" ] 1758 common_flags = [ "-fobjc-arc" ]
1756 cflags_objc = common_flags 1759 cflags_objc = common_flags
1757 cflags_objcc = common_flags 1760 cflags_objcc = common_flags
1758 } 1761 }
1759 } 1762 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698