DescriptionReland of build: Enable optimize_for_size unconditionally. (patchset #1 id:1 of https://codereview.chromium.org/2881503002/ )
Reason for revert:
Relanding now that the msan issue is fixed: https://codereview.chromium.org/2876693003
Original issue's description:
> Revert of build: Enable optimize_for_size unconditionally. (patchset #1 id:1 of https://codereview.chromium.org/2864383003/ )
>
> Reason for revert:
> Causes failures on a MSAN bot.
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/440
>
>
> Original issue's description:
> > build: Enable optimize_for_size unconditionally.
> >
> > This change causes us to favor size over speed on Linux and Mac,
> > which aligns the build config for those platforms with that of the
> > other supported platforms, and should reduce the binary size impact
> > of enabling ThinLTO. This change is expected to reduce binary size
> > for Linux official builds by about 15%.
> >
> > There may be unacceptable perf regressions associated with this
> > change, but the perf bots should at least let us know where those
> > regressions are. I plan to monitor the Linux and Mac perf bots once
> > it lands.
> >
> > BUG=660216
> > R=thakis@chromium.org
> >
> > Review-Url: https://codereview.chromium.org/2864383003
> > Cr-Commit-Position: refs/heads/master@{#470606}
> > Committed: https://chromium.googlesource.com/chromium/src/+/c1269ce7fec8568a1789e07b2b5bb3b630a67f5f
>
> TBR=thakis@chromium.org,pcc@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=660216
>
> Review-Url: https://codereview.chromium.org/2881503002
> Cr-Commit-Position: refs/heads/master@{#470793}
> Committed: https://chromium.googlesource.com/chromium/src/+/2a6f440fa84a584d916254f9a4c4e4d83c53435f
TBR=thakis@chromium.org,yhirano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=660216
Review-Url: https://codereview.chromium.org/2870393005
Cr-Commit-Position: refs/heads/master@{#471046}
Committed: https://chromium.googlesource.com/chromium/src/+/ea5fad44dd0b0a74a40dbe2c05598f43861cd75a
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|