build/config/compiler/BUILD.gn - Issue 2881503002: Revert of build: Enable optimize_for_size unconditionally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 2881503002: Revert of build: Enable optimize_for_size unconditionally. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 5216fec230f92058d3411b8b315a152b35fb7ef5..183654cfd4e92aeeeca0f21255cb589b45f777a5 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -74,7 +74,10 @@

(is_chromecast && !is_cast_desktop_build && !is_debug)

# If true, optimize for size. Does not affect windows builds.

- optimize_for_size = true

+ # Linux & Mac favor speed over size.

+ # TODO(brettw) it's weird that Mac and desktop Linux are different. We should

+ # explore favoring size over speed in this case as well.

+ optimize_for_size = is_android || is_ios

# Enable fatal linker warnings. Building Chromium with certain versions

# of binutils can cause linker warning.

« no previous file with comments | « no previous file | no next file » | no next file with comments »