Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2880173002: Clean up StyleInheritedData. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up StyleInheritedData. In preparation to generate StyleInheritedData, this patch removes the StyleInherited destructor and copy constructor, since they are generated by the compiler anyway. BUG=628043 Review-Url: https://codereview.chromium.org/2880173002 Cr-Commit-Position: refs/heads/master@{#471672} Committed: https://chromium.googlesource.com/chromium/src/+/b7a5c55bb3f841ff77446c65edfe56bcc1f893a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M third_party/WebKit/Source/core/style/StyleInheritedData.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleInheritedData.cpp View 1 chunk +0 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-14 23:29:31 UTC) #4
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-15 04:04:47 UTC) #7
meade_UTC10
lgtm lgtm
3 years, 7 months ago (2017-05-15 04:04:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880173002/1
3 years, 7 months ago (2017-05-15 05:20:33 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 05:24:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b7a5c55bb3f841ff77446c65edfe...

Powered by Google App Engine
This is Rietveld 408576698