Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 2883803002: Move StyleInheritedData.cpp to be inline in StyleInheritedData.h. (Closed)

Created:
1 year, 7 months ago by shend
Modified:
1 year, 7 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move StyleInheritedData.cpp to be inline in StyleInheritedData.h. This patch removes StyleInheritedData.cpp, and moves all its contents to be inline in StyleInheritedData.h This is prework for generating StyleInheritedData. BUG=628043 Review-Url: https://codereview.chromium.org/2883803002 Cr-Commit-Position: refs/heads/master@{#471691} Committed: https://chromium.googlesource.com/chromium/src/+/c0cd99cb52e33e76170b3bb7936233fbb85fa3ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -48 lines) Patch
M third_party/WebKit/Source/core/style/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleInheritedData.h View 2 chunks +16 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/style/StyleInheritedData.cpp View 1 chunk +0 lines, -45 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
shend
Hi Eddy, PTAL (no bots due to dependency)
1 year, 7 months ago (2017-05-14 23:29:20 UTC) #4
meade_UTC10
lgtm
1 year, 7 months ago (2017-05-15 03:59:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883803002/1
1 year, 7 months ago (2017-05-15 07:51:15 UTC) #13
commit-bot: I haz the power
1 year, 7 months ago (2017-05-15 07:56:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c0cd99cb52e33e76170b3bb79362...

Powered by Google App Engine
This is Rietveld 408576698