Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Side by Side Diff: third_party/WebKit/Source/core/style/StyleInheritedData.h

Issue 2880173002: Clean up StyleInheritedData. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/StyleInheritedData.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 19 matching lines...) Expand all
30 #include "platform/fonts/Font.h" 30 #include "platform/fonts/Font.h"
31 #include "platform/graphics/Color.h" 31 #include "platform/graphics/Color.h"
32 #include "platform/wtf/PassRefPtr.h" 32 #include "platform/wtf/PassRefPtr.h"
33 #include "platform/wtf/RefCounted.h" 33 #include "platform/wtf/RefCounted.h"
34 34
35 namespace blink { 35 namespace blink {
36 36
37 // TODO(sashab): Move this into a private class on ComputedStyle, and remove 37 // TODO(sashab): Move this into a private class on ComputedStyle, and remove
38 // all methods on it, merging them into copy/creation methods on ComputedStyle 38 // all methods on it, merging them into copy/creation methods on ComputedStyle
39 // instead. Keep the allocation logic, only allocating a new object if needed. 39 // instead. Keep the allocation logic, only allocating a new object if needed.
40 class CORE_EXPORT StyleInheritedData : public RefCounted<StyleInheritedData> { 40 class CORE_EXPORT StyleInheritedData
41 : public RefCountedCopyable<StyleInheritedData> {
41 public: 42 public:
42 static PassRefPtr<StyleInheritedData> Create() { 43 static PassRefPtr<StyleInheritedData> Create() {
43 return AdoptRef(new StyleInheritedData); 44 return AdoptRef(new StyleInheritedData);
44 } 45 }
45 PassRefPtr<StyleInheritedData> Copy() const { 46 PassRefPtr<StyleInheritedData> Copy() const {
46 return AdoptRef(new StyleInheritedData(*this)); 47 return AdoptRef(new StyleInheritedData(*this));
47 } 48 }
48 ~StyleInheritedData();
49 49
50 bool operator==(const StyleInheritedData&) const; 50 bool operator==(const StyleInheritedData&) const;
51 bool operator!=(const StyleInheritedData& o) const { return !(*this == o); } 51 bool operator!=(const StyleInheritedData& o) const { return !(*this == o); }
52 52
53 short horizontal_border_spacing_; 53 short horizontal_border_spacing_;
54 short vertical_border_spacing_; 54 short vertical_border_spacing_;
55 55
56 // could be packed in a short but doesn't 56 // could be packed in a short but doesn't
57 // make a difference currently because of padding 57 // make a difference currently because of padding
58 Length line_height_; 58 Length line_height_;
59 59
60 Font font_; 60 Font font_;
61 Color color_; 61 Color color_;
62 Color visited_link_color_; 62 Color visited_link_color_;
63 float text_autosizing_multiplier_; 63 float text_autosizing_multiplier_;
64 64
65 private: 65 private:
66 StyleInheritedData(); 66 StyleInheritedData();
67 StyleInheritedData(const StyleInheritedData&); 67 StyleInheritedData(const StyleInheritedData&) = default;
68 }; 68 };
69 69
70 } // namespace blink 70 } // namespace blink
71 71
72 #endif // StyleInheritedData_h 72 #endif // StyleInheritedData_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/StyleInheritedData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698