Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Unified Diff: third_party/WebKit/Source/core/style/StyleInheritedData.h

Issue 2880173002: Clean up StyleInheritedData. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/StyleInheritedData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/StyleInheritedData.h
diff --git a/third_party/WebKit/Source/core/style/StyleInheritedData.h b/third_party/WebKit/Source/core/style/StyleInheritedData.h
index 32a5588b8ff466e6d904010959f1a880a0285362..bbcbe483251b93d78a57e9676ae3ec8c1c177161 100644
--- a/third_party/WebKit/Source/core/style/StyleInheritedData.h
+++ b/third_party/WebKit/Source/core/style/StyleInheritedData.h
@@ -37,7 +37,8 @@ namespace blink {
// TODO(sashab): Move this into a private class on ComputedStyle, and remove
// all methods on it, merging them into copy/creation methods on ComputedStyle
// instead. Keep the allocation logic, only allocating a new object if needed.
-class CORE_EXPORT StyleInheritedData : public RefCounted<StyleInheritedData> {
+class CORE_EXPORT StyleInheritedData
+ : public RefCountedCopyable<StyleInheritedData> {
public:
static PassRefPtr<StyleInheritedData> Create() {
return AdoptRef(new StyleInheritedData);
@@ -45,7 +46,6 @@ class CORE_EXPORT StyleInheritedData : public RefCounted<StyleInheritedData> {
PassRefPtr<StyleInheritedData> Copy() const {
return AdoptRef(new StyleInheritedData(*this));
}
- ~StyleInheritedData();
bool operator==(const StyleInheritedData&) const;
bool operator!=(const StyleInheritedData& o) const { return !(*this == o); }
@@ -64,7 +64,7 @@ class CORE_EXPORT StyleInheritedData : public RefCounted<StyleInheritedData> {
private:
StyleInheritedData();
- StyleInheritedData(const StyleInheritedData&);
+ StyleInheritedData(const StyleInheritedData&) = default;
};
} // namespace blink
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/StyleInheritedData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698