ContentSuggestionsDataSource returns CollectionViewItem

ContentSuggestionsDataSource returns CollectionViewItem

Before this CL, ContentSuggestionsDataSource returned ContentSuggestion.
The ContentSuggestion were converted into CollectionViewItem in the
ContentSuggestionsCollectionUpdater, then added to the collection.

This CL changes the ContentSuggestionsDataSource and makes it return
CollectionViewItem directly. ContentSuggestion is removed as it is no longer
needed.

BUG=720271, 706344
Review-Url: https://codereview.chromium.org/2877513003
Cr-Commit-Position: refs/heads/master@{#471784}
Committed: https://chromium.googlesource.com/chromium/src/+/98264ec53c6ff8523e659903bd489483686622a5

[gambard, 2017-05-11 15:43:10]

Description was changed from

==========
ContentSuggestionsDataSource return CollectionViewItem

Before this CL, ContentSuggestionsDataSource returned ContentSuggestion.
The ContentSuggestion were converted into CollectionViewItem in the
ContentSuggestionsCollectionUpdater, then added to the collection.

This CL changes the ContentSuggestionsDataSource and makes it return
CollectionViewItem directly. ContentSuggestion is removed as it is no longer
needed.

BUG=720271
==========

to

==========
ContentSuggestionsDataSource return CollectionViewItem

Before this CL, ContentSuggestionsDataSource returned ContentSuggestion.
The ContentSuggestion were converted into CollectionViewItem in the
ContentSuggestionsCollectionUpdater, then added to the collection.

This CL changes the ContentSuggestionsDataSource and makes it return
CollectionViewItem directly. ContentSuggestion is removed as it is no longer
needed.

BUG=720271, 706344
==========

[gambard, 2017-05-11 15:45:39]

gambard@chromium.org changed reviewers:
+ jif@chromium.org

[gambard, 2017-05-11 15:45:40]

PTAL!

[gambard, 2017-05-11 15:45:49]

Description was changed from

==========
ContentSuggestionsDataSource return CollectionViewItem

Before this CL, ContentSuggestionsDataSource returned ContentSuggestion.
The ContentSuggestion were converted into CollectionViewItem in the
ContentSuggestionsCollectionUpdater, then added to the collection.

This CL changes the ContentSuggestionsDataSource and makes it return
CollectionViewItem directly. ContentSuggestion is removed as it is no longer
needed.

BUG=720271, 706344
==========

to

==========
ContentSuggestionsDataSource returns CollectionViewItem

Before this CL, ContentSuggestionsDataSource returned ContentSuggestion.
The ContentSuggestion were converted into CollectionViewItem in the
ContentSuggestionsCollectionUpdater, then added to the collection.

This CL changes the ContentSuggestionsDataSource and makes it return
CollectionViewItem directly. ContentSuggestion is removed as it is no longer
needed.

BUG=720271, 706344
==========

[jif, 2017-05-15 11:14:47]

thanks for the description.

lgtm with nits

https://codereview.chromium.org/2877513003/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
(right):

https://codereview.chromium.org/2877513003/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm:382: //
them to the |contentArray|  if the category is available.
remove extra space before "if"

https://codereview.chromium.org/2877513003/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h
(right):

https://codereview.chromium.org/2877513003/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h:39:
@property(nonatomic, assign)
should be weak to make it impossible to have a dangling pointer

[gambard, 2017-05-15 12:50:03]

Thanks!

https://codereview.chromium.org/2877513003/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
(right):

https://codereview.chromium.org/2877513003/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm:382: //
them to the |contentArray|  if the category is available.
On 2017/05/15 11:14:47, jif wrote:
> remove extra space before "if"

Done.

https://codereview.chromium.org/2877513003/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h
(right):

https://codereview.chromium.org/2877513003/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h:39:
@property(nonatomic, assign)
On 2017/05/15 11:14:47, jif wrote:
> should be weak to make it impossible to have a dangling pointer

Nice catch!
Done.

[gambard, 2017-05-15 12:50:07]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-05-15 12:50:07]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org
Link to the patchset: https://codereview.chromium.org/2877513003/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-05-15 12:50:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 13:00:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 13:00:25]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[gambard, 2017-05-15 13:01:21]

gambard@chromium.org changed reviewers:
+ sdefresne@chromium.org

[gambard, 2017-05-15 13:01:22]

sdefresne: PTAL
ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm

[sdefresne, 2017-05-15 13:17:05]

ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm lgtm

[gambard, 2017-05-15 13:17:39]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2017-05-15 13:17:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 16:26:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494854259059300,
"parent_rev": "9a2fd54ac4061f0c26a00e3d9d3396095c8e1675", "commit_rev":
"98264ec53c6ff8523e659903bd489483686622a5"}

[commit-bot: I haz the power, 2017-05-15 16:26:32]

Description was changed from

==========
ContentSuggestionsDataSource returns CollectionViewItem

Before this CL, ContentSuggestionsDataSource returned ContentSuggestion.
The ContentSuggestion were converted into CollectionViewItem in the
ContentSuggestionsCollectionUpdater, then added to the collection.

This CL changes the ContentSuggestionsDataSource and makes it return
CollectionViewItem directly. ContentSuggestion is removed as it is no longer
needed.

BUG=720271, 706344
==========

to

==========
ContentSuggestionsDataSource returns CollectionViewItem

Before this CL, ContentSuggestionsDataSource returned ContentSuggestion.
The ContentSuggestion were converted into CollectionViewItem in the
ContentSuggestionsCollectionUpdater, then added to the collection.

This CL changes the ContentSuggestionsDataSource and makes it return
CollectionViewItem directly. ContentSuggestion is removed as it is no longer
needed.

BUG=720271, 706344

Review-Url: https://codereview.chromium.org/2877513003
Cr-Commit-Position: refs/heads/master@{#471784}
Committed:
https://chromium.googlesource.com/chromium/src/+/98264ec53c6ff8523e659903bd48...
==========

[commit-bot: I haz the power, 2017-05-15 16:26:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/98264ec53c6ff8523e659903bd48...