Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2887433002: Move the ContentSuggestions items to a new target (Closed)

Created:
3 years, 7 months ago by gambard
Modified:
3 years, 7 months ago
Reviewers:
jif, sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the ContentSuggestions items to a new target The ContentSuggestions items contain GURL. The GURL cannot be included in the UI layer. This CL moves the ContentSuggestionsItem and ContentSuggestionsMostVisitedItem to a new target, keeping the associated cells in the old target in new files. BUG=720271 Review-Url: https://codereview.chromium.org/2887433002 Cr-Commit-Position: refs/heads/master@{#472053} Committed: https://chromium.googlesource.com/chromium/src/+/765e161bf83b6625bdd01796594b4fcc63c91762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -629 lines) Patch
M ios/chrome/browser/content_suggestions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm View 3 chunks +9 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn View 3 chunks +21 lines, -3 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.h View 3 chunks +4 lines, -36 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm View 3 chunks +2 lines, -69 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.h View 2 chunks +0 lines, -27 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm View 2 chunks +4 lines, -320 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item_unittest.mm View 3 chunks +3 lines, -1 line 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.h View 2 chunks +3 lines, -21 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.mm View 2 chunks +1 line, -34 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.h View 2 chunks +0 lines, -17 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm View 2 chunks +1 line, -71 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h View 1 chunk +5 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm View 4 chunks +2 lines, -16 lines 0 comments Download
M ios/chrome/browser/ui/settings/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
gambard
PTAL :)
3 years, 7 months ago (2017-05-15 13:43:57 UTC) #2
jif
lgtm
3 years, 7 months ago (2017-05-15 17:30:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887433002/1
3 years, 7 months ago (2017-05-16 07:09:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/437985)
3 years, 7 months ago (2017-05-16 07:18:22 UTC) #7
gambard
sdefresne: PTAL at ios/chrome/browser/ui/settings/BUILD.gn
3 years, 7 months ago (2017-05-16 07:22:11 UTC) #9
sdefresne
lgtm
3 years, 7 months ago (2017-05-16 09:26:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887433002/1
3 years, 7 months ago (2017-05-16 09:27:41 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 09:33:22 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/765e161bf83b6625bdd01796594b...

Powered by Google App Engine
This is Rietveld 408576698