ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm - Issue 2877513003: ContentSuggestionsDataSource returns CollectionViewItem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm

Issue 2877513003: ContentSuggestionsDataSource returns CollectionViewItem (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.h ('k') | ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm

diff --git a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm

index ffa77783fd2e258197fee48f4b17510300ee38d7..985d5828e83410ff73049671b6e7b1c72390579f 100644

--- a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm

+++ b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm

@@ -6,6 +6,7 @@

#include "base/time/time.h"

#import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"

+#import "ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion_identifier.h"

#import "ios/chrome/browser/ui/favicon/favicon_attributes.h"

#import "ios/chrome/browser/ui/favicon/favicon_view.h"

#import "ios/chrome/browser/ui/uikit_ui_util.h"

@@ -74,7 +75,6 @@ const CGFloat kAnimationDuration = 0.3;

- (instancetype)initWithType:(NSInteger)type

title:(NSString*)title

subtitle:(NSString*)subtitle

- delegate:(id<ContentSuggestionsItemDelegate>)delegate

url:(const GURL&)url {

self = [super initWithType:type];

if (self) {

@@ -82,7 +82,6 @@ const CGFloat kAnimationDuration = 0.3;

_title = [title copy];

_subtitle = [subtitle copy];

_URL = url;

- _delegate = delegate;

}

return self;

}

@@ -92,7 +91,7 @@ const CGFloat kAnimationDuration = 0.3;

if (self.hasImage && !self.imageFetched) {

self.imageFetched = YES;

// Fetch the image. During the fetch the cell's image should still be set.

- [self.delegate loadImageForSuggestionItem:self];

+ [self.delegate loadImageForSuggestedItem:self];

}

[cell.faviconView configureWithAttributes:self.attributes];

cell.titleLabel.text = self.title;