ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h - Issue 2877513003: ContentSuggestionsDataSource returns CollectionViewItem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h

Issue 2877513003: ContentSuggestionsDataSource returns CollectionViewItem (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion_identifier.h ('k') | ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h

diff --git a/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h b/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h

index f2f2d8b4c2b5727798b7271e67c8e21bac03818f..e2aea5a17ad7f5775c63ce540c164bd98b0be69c 100644

--- a/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h

+++ b/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h

@@ -15,10 +15,8 @@ typedef NS_ENUM(NSInteger, ContentSuggestionsSectionLayout) {

ContentSuggestionsSectionLayoutCustom,

};

-// This enum is used for ordering the sections and as ID for the section. Make

-// all sections in the same collection have different ID.

-// When adding a new kind of suggestions, add a new corresponding section. The

-// ordering is not persisted between launch, reordering is possible.

+// This enum is used for identifying the section. All section should have a

+// different ID.

typedef NS_ENUM(NSInteger, ContentSuggestionsSectionID) {

ContentSuggestionsSectionMostVisited = 0,

ContentSuggestionsSectionArticles,