[TTS] Remove the blacklist and first char metrics.

[TTS] Remove the blacklist and first char metrics.

We were recording the first character of the selection to use as
a hint for triggering.  We don't currently have permission to send
this to Ranker so it's being removed for now, and the histogram being
marked obsolete.

We don't yet have permission to send any content signals to Ranker
so removing some promising ones like word-length from the send-to-ranker
list but keeping the underlying data collection for now.

Remove the entire blacklist and obsoleting the associated histogram.

BUG=720193
Review-Url: https://codereview.chromium.org/2875553002
Cr-Commit-Position: refs/heads/master@{#471058}
Committed: https://chromium.googlesource.com/chromium/src/+/ad9a27a4d180efbc526c04545e9eea31f8dcecb7

[Donn Denman, 2017-05-10 02:22:47]

The CQ bit was checked by donnd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 02:23:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 04:25:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 04:25:46]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))

[Donn Denman, 2017-05-10 18:33:19]

donnd@chromium.org changed reviewers:
+ twellington@chromium.org

[Donn Denman, 2017-05-10 18:33:20]

Theresa, PTAL.  Thanks!

[Theresa, 2017-05-10 18:47:09]

https://codereview.chromium.org/2875553002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
(left):

https://codereview.chromium.org/2875553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java:136:
ContextualSearchUma.logStartedWithCapitalResultsSeen(mWasSearchContentViewSeen);
This method still needs to be removed from ContextualSearchUma and the
corresponding histogram needs to be deprecated.

https://codereview.chromium.org/2875553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java:326:
ContextualSearchRankerLogger.Feature.SELECTION_FIRST_CHAR, mSelectionFirstChar);
I understand not having permission for the first character, but do we still have
permission for selection length and whether the first character is capitalized?

https://codereview.chromium.org/2875553002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchBlacklist.java
(left):

https://codereview.chromium.org/2875553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchBlacklist.java:139:
codes.put(new BlacklistSeenKey(BlacklistReason.NUMBER, false), NUMBER_NOT_SEEN);
The one promising thing from the blacklist was single digits. Is there a way to
retain that as a Ranker feature?

[Donn Denman, 2017-05-10 21:26:40]

Description was changed from

==========
[TTS] Remove the blacklist and first char metrics.

We were recording the first character of the selection to use as
a hint for triggering.  We don't currently have permission to send
this to Ranker so it's being removed for now, and the histogram being
marked obsolete.

Remove the entire blacklist and obsoleting the associated histogram.

BUG=720193
==========

to

==========
[TTS] Remove the blacklist and first char metrics.

We were recording the first character of the selection to use as
a hint for triggering.  We don't currently have permission to send
this to Ranker so it's being removed for now, and the histogram being
marked obsolete.

We don't yet have permission to send any content signals to Ranker so removing
some promising ones like word-length from the send-to-ranker list but keeping
the underlying data collection for now.

Remove the entire blacklist and obsoleting the associated histogram.

BUG=720193
==========

[Donn Denman, 2017-05-10 21:28:33]

Description was changed from

==========
[TTS] Remove the blacklist and first char metrics.

We were recording the first character of the selection to use as
a hint for triggering.  We don't currently have permission to send
this to Ranker so it's being removed for now, and the histogram being
marked obsolete.

We don't yet have permission to send any content signals to Ranker so removing
some promising ones like word-length from the send-to-ranker list but keeping
the underlying data collection for now.

Remove the entire blacklist and obsoleting the associated histogram.

BUG=720193
==========

to

==========
[TTS] Remove the blacklist and first char metrics.

We were recording the first character of the selection to use as
a hint for triggering.  We don't currently have permission to send
this to Ranker so it's being removed for now, and the histogram being
marked obsolete.

We don't yet have permission to send any content signals to Ranker
so removing some promising ones like word-length from the send-to-ranker
list but keeping the underlying data collection for now.

Remove the entire blacklist and obsoleting the associated histogram.

BUG=720193
==========

[Donn Denman, 2017-05-10 21:28:55]

Theresa, PTAL.  Thanks!

https://codereview.chromium.org/2875553002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
(left):

https://codereview.chromium.org/2875553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java:136:
ContextualSearchUma.logStartedWithCapitalResultsSeen(mWasSearchContentViewSeen);
On 2017/05/10 18:47:09, Theresa wrote:
> This method still needs to be removed from ContextualSearchUma and the
> corresponding histogram needs to be deprecated.

Done.

https://codereview.chromium.org/2875553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java:326:
ContextualSearchRankerLogger.Feature.SELECTION_FIRST_CHAR, mSelectionFirstChar);
On 2017/05/10 18:47:09, Theresa wrote:
> I understand not having permission for the first character, but do we still
have
> permission for selection length and whether the first character is
capitalized?

We didn't get permission for any content signals yet, including word length and
capitalization.  I do think that word length is a very useful feature, so I
think we should keep logging it and hope to get permission to send it to Ranker.
 Also Tap-offset used in conjunction with word-length to get a
<tapped-word-middle> feature could give a good signal for some users that they
were targeting the middle of that word with their tap.

Sorry I didn't explain this better in the CL description!

https://codereview.chromium.org/2875553002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchBlacklist.java
(left):

https://codereview.chromium.org/2875553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchBlacklist.java:139:
codes.put(new BlacklistSeenKey(BlacklistReason.NUMBER, false), NUMBER_NOT_SEEN);
On 2017/05/10 18:47:09, Theresa wrote:
> The one promising thing from the blacklist was single digits. Is there a way
to
> retain that as a Ranker feature?

I think whatever happens with the handling of content will determine how we'll
treat specific content like numbers.  I'll try to remember that numbers had
significantly lower CTR for when we're doing analysis of the content for Ranker.
 We'll almost certainly need some way to recognize phone-numbers too.  I've
added a comment in my go/cs-ml-ctr document to record this for later.

[Theresa, 2017-05-10 21:39:45]

lgtm

[Donn Denman, 2017-05-10 21:42:33]

donnd@chromium.org changed reviewers:
+ holte@chromium.org

[Donn Denman, 2017-05-10 21:42:33]

Steven, PTAL at histograms.xml.  Thanks!

[Steven Holte, 2017-05-11 17:40:21]

lgtm

[Donn Denman, 2017-05-11 17:40:54]

The CQ bit was checked by donnd@chromium.org

[commit-bot: I haz the power, 2017-05-11 17:42:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 20:35:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494524454676880,
"parent_rev": "9ac1e972f92e44597cf8c9a0473fa2fc7f50655e", "commit_rev":
"ad9a27a4d180efbc526c04545e9eea31f8dcecb7"}

[commit-bot: I haz the power, 2017-05-11 20:35:49]

Description was changed from

==========
[TTS] Remove the blacklist and first char metrics.

We were recording the first character of the selection to use as
a hint for triggering.  We don't currently have permission to send
this to Ranker so it's being removed for now, and the histogram being
marked obsolete.

We don't yet have permission to send any content signals to Ranker
so removing some promising ones like word-length from the send-to-ranker
list but keeping the underlying data collection for now.

Remove the entire blacklist and obsoleting the associated histogram.

BUG=720193
==========

to

==========
[TTS] Remove the blacklist and first char metrics.

We were recording the first character of the selection to use as
a hint for triggering.  We don't currently have permission to send
this to Ranker so it's being removed for now, and the histogram being
marked obsolete.

We don't yet have permission to send any content signals to Ranker
so removing some promising ones like word-length from the send-to-ranker
list but keeping the underlying data collection for now.

Remove the entire blacklist and obsoleting the associated histogram.

BUG=720193

Review-Url: https://codereview.chromium.org/2875553002
Cr-Commit-Position: refs/heads/master@{#471058}
Committed:
https://chromium.googlesource.com/chromium/src/+/ad9a27a4d180efbc526c04545e9e...
==========

[commit-bot: I haz the power, 2017-05-11 20:35:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ad9a27a4d180efbc526c04545e9e...