Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1887)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java

Issue 2875553002: [TTS] Remove the blacklist and first char metrics. (Closed)
Patch Set: Removed and obsoleted the started-with-capital uma and histogram. Plus a rebase. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
index 0bae670e212bf72a46e62ceb5f45629fc8b34213..b1acdc6183018c7b86a0e7d97431344f19295235 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
@@ -10,7 +10,6 @@ import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.PanelState;
import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;
-import org.chromium.chrome.browser.contextualsearch.ContextualSearchBlacklist.BlacklistReason;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import java.util.Collections;
@@ -803,18 +802,6 @@ public class ContextualSearchUma {
}
}
- /**
- * Logs whether results were seen when the selected text started with a capital letter but was
- * not all capital letters.
- * @param wasSearchContentViewSeen If the panel was opened.
- */
- public static void logStartedWithCapitalResultsSeen(boolean wasSearchContentViewSeen) {
- RecordHistogram.recordEnumeratedHistogram(
- "Search.ContextualSearchStartedWithCapitalResultsSeen",
- wasSearchContentViewSeen ? RESULTS_SEEN : RESULTS_NOT_SEEN,
- RESULTS_SEEN_BOUNDARY);
- }
-
/**
* Logs whether results were seen and whether any tap suppression heuristics were satisfied.
* @param wasSearchContentViewSeen If the panel was opened.
@@ -1135,19 +1122,6 @@ public class ContextualSearchUma {
"Search.ContextualSearchShouldTranslate", code, FORCE_TRANSLATE_BOUNDARY);
}
- /**
- * Logs whether a certain category of a blacklisted term resulted in the search results
- * being seen.
- * @param reason The given reason.
- * @param wasSeen Whether the search results were seen.
- */
- public static void logBlacklistSeen(BlacklistReason reason, boolean wasSeen) {
- if (reason == null) reason = BlacklistReason.NONE;
- int code = ContextualSearchBlacklist.getBlacklistMetricsCode(reason, wasSeen);
- RecordHistogram.recordEnumeratedHistogram("Search.ContextualSearchBlacklistSeen",
- code, ContextualSearchBlacklist.BLACKLIST_BOUNDARY);
- }
-
/**
* Logs whether Contextual Cards data was shown. Should be logged on tap if Contextual
* Cards integration is enabled.

Powered by Google App Engine
This is Rietveld 408576698