chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java - Issue 2875553002: [TTS] Remove the blacklist and first char metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 2875553002: [TTS] Remove the blacklist and first char metrics. (Closed)

Patch Set: Removed and obsoleted the started-with-capital uma and histogram. Plus a rebase. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchBlacklist.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

index fa67917d188d522a0fa2809416294c7bfcb7de65..bfd5f6e78b0304385246b1e2ab64ea5c042fcf51 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

@@ -24,7 +24,6 @@ import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.PanelState;

import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;

import org.chromium.chrome.browser.compositor.bottombar.OverlayPanelContentViewDelegate;

import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanel;

-import org.chromium.chrome.browser.contextualsearch.ContextualSearchBlacklist.BlacklistReason;

import org.chromium.chrome.browser.contextualsearch.ContextualSearchInternalStateController.InternalState;

import org.chromium.chrome.browser.contextualsearch.ContextualSearchSelectionController.SelectionType;

import org.chromium.chrome.browser.externalnav.ExternalNavigationHandler;

@@ -1352,13 +1351,6 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega

}

- @Override

- public void handleSelectionSuppression(BlacklistReason reason) {

- if (mIsAccessibilityModeEnabled) return;

- if (mSearchPanel != null) mSearchPanel.getPanelMetrics().setBlacklistReason(reason);

- }

@Override

public void handleSelectionCleared() {

// The selection was just cleared, so we'll want to remove our UX unless it was due to