chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java - Issue 2875553002: [TTS] Remove the blacklist and first char metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java

Issue 2875553002: [TTS] Remove the blacklist and first char metrics. (Closed)

Patch Set: Removed and obsoleted the started-with-capital uma and histogram. Plus a rebase. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java

index 5a40ac5d0cd66f6ab2f2e04d2c336d5dac74cedc..c2472f52a063530b64c3dc410f1714490152df36 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java

@@ -9,7 +9,6 @@ import android.text.TextUtils;

import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel;

-import org.chromium.chrome.browser.contextualsearch.ContextualSearchBlacklist.BlacklistReason;

import org.chromium.chrome.browser.preferences.ChromePreferenceManager;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.content.browser.ContentViewCore;

@@ -489,19 +488,6 @@ public class ContextualSearchSelectionController {

boolean isValid = isValidSelection(selection);

if (mSelectionType == SelectionType.TAP) {

- BlacklistReason reason =

- ContextualSearchBlacklist.findReasonToSuppressSelection(selection);

- mHandler.handleSelectionSuppression(reason);

- // Only really suppress if enabled by field trial. Currently we can't prevent a

- // selection from being issued, so we end up clearing the selection immediately

- // afterwards, which does not look great.

- // TODO(pedrosimonetti): actually suppress selection once the system supports it.

- if (ContextualSearchFieldTrial.isBlacklistEnabled() && reason != BlacklistReason.NONE) {

- isValid = false;

- }

int minSelectionLength = ContextualSearchFieldTrial.getMinimumSelectionLength();

if (selection.length() < minSelectionLength) {

isValid = false;