Landing Recent QUIC changes until Mon May 8 21:42:46 2017 +0000

Landing Recent QUIC changes until Mon May 8 21:42:46 2017 +0000

Add QUIC v40 which will be used to include changes:
1) Initial packet number is randomly chosen from [0:2^31]
2) WINDOW_UPDATE for connection flow control advertises value in 1024-byte units
3) Window updates split into MAX_DATA and MAX_STREAM_DATA
4) BLOCKED frame split into BLOCKED and STREAM_BLOCKED frames
Merge internal change: 155429780
https://codereview.chromium.org/2879533003/


Do not wrap a PCC sender with a PacingSender.
Right now, we cannot just blindly wrap a PCC-based sender with a
PacingSender.  Some SendAlgorithms can be wrapped by a pacer and some
cannot.  By default, do  not wrap a PCC sender with a pacer.
Merge internal change: 155393218
https://codereview.chromium.org/2881623002/


Deprecate FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming
Results in getting rid of all setting/getting of bidirectional_data member
variables, and a bunch of tests.
Merge internal change: 155389424
https://codereview.chromium.org/2872133008/


Migrate deprecated StringPiece::CopyToString to string::assign (or construction
of string, if appropriate)
Merge internal change: 155349312
https://codereview.chromium.org/2874913003/


Create scaffolding for experimenting with PCC.  Protected by
FLAGS_quic_reloadable_flag_quic_enable_pcc.
This code adds support for a new congestion-control algorithm, called
PCC, to be used by QUIC.
Merge internal change: 155088982
https://codereview.chromium.org/2874243004/


Revert two changes written by non-Googler authors.
Merge internal change: 155026903
https://codereview.chromium.org/2869273009/


Add relevant tags for PCC Congestion control
These will be used in the future to identify the PCC experiment and
the PCC congestion-control algorithm within the code.
Merge internal change: 154967674
https://codereview.chromium.org/2882503002/


Close the connection after 3RTOs if there are no open streams and the 3RTO
connection option is supplied.  Protected by
FLAGS_quic_reloadable_flag_quic_enable_3rtos.
Merge internal change: 154823650
https://codereview.chromium.org/2874033002/


Deprecate FLAGS_quic_reloadable_flag_quic_bbr_base_cwnd_on_srtt in disabled state.
Merge internal change: 154780925
https://codereview.chromium.org/2870333002/


Add QUIC handshake accounting. Protected by
FLAGS_quic_reloadable_flag_quic_account_handshake.
Merge internal change: 154763851
https://codereview.chromium.org/2873883002/


Allow customization of client address used for stateless rejector to
generate and validate source address token. Protected by
FLAGS_quic_reloadable_flag_quic_use_client_address_for_stk_in_proxy.
Merge internal change: 154755746
https://codereview.chromium.org/2876443002/


R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2875333002
Cr-Commit-Position: refs/heads/master@{#471448}
Committed: https://chromium.googlesource.com/chromium/src/+/42a0166c209d0fbc20e0adb4bf352571804e0a07

[Ryan Hamilton, 2017-05-12 17:39:18]

looks good though I'm surprised not to see any flag flips. Were there none this
week?

[mpw, 2017-05-12 18:13:40]

It seems not: I did run /home/build/google3/gfe/quic/tools/update_flags.py,
but it did not result in any changes.  Checking CLs affecting QUIC feature
flags in the CL range for this week, I do not see any that change the
default value of any flags.

On Fri, May 12, 2017 at 1:39 PM, <rch@chromium.org> wrote:

> looks good though I'm surprised not to see any flag flips. Were there none
> this
> week?
>
> https://codereview.chromium.org/2875333002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ryan Hamilton, 2017-05-12 18:17:12]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-05-12 18:17:13]

lgtm

[commit-bot: I haz the power, 2017-05-12 18:18:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 18:50:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 18:50:19]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mpw, 2017-05-12 18:58:49]

Description was changed from

==========
Landing Recent QUIC changes until Mon May 8 21:42:46 2017 +0000

Add QUIC v40 which will be used to include changes:
1) Initial packet number is randomly chosen from [0:2^31]
2) WINDOW_UPDATE for connection flow control advertises value in 1024-byte units
3) Window updates split into MAX_DATA and MAX_STREAM_DATA
4) BLOCKED frame split into BLOCKED and STREAM_BLOCKED frames
Merge internal change: 155429780
https://codereview.chromium.org/2879533003/


Do not wrap a PCC sender with a PacingSender.
Right now, we cannot just blindly wrap a PCC-based sender with a
PacingSender.  Some SendAlgorithms can be wrapped by a pacer and some
cannot.  By default, do  not wrap a PCC sender with a pacer.
Merge internal change: 155393218
https://codereview.chromium.org/2881623002/


Deprecate FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming
Results in getting rid of all setting/getting of bidirectional_data member
variables, and a bunch of tests.
Merge internal change: 155389424
https://codereview.chromium.org/2872133008/


Migrate deprecated StringPiece::CopyToString to string::assign (or construction
of string, if appropriate)
Merge internal change: 155349312
https://codereview.chromium.org/2874913003/


Create scaffolding for experimenting with PCC.  Protected by
FLAGS_quic_reloadable_flag_quic_enable_pcc.
This code adds support for a new congestion-control algorithm, called
PCC, to be used by QUIC.
Merge internal change: 155088982
https://codereview.chromium.org/2874243004/


Revert two changes written by non-Googler authors.
Merge internal change: 155026903
https://codereview.chromium.org/2869273009/


Add relevant tags for PCC Congestion control
These will be used in the future to identify the PCC experiment and
the PCC congestion-control algorithm within the code.
Merge internal change: 154967674
https://codereview.chromium.org/2882503002/


Close the connection after 3RTOs if there are no open streams and the 3RTO
connection option is supplied.  Protected by
FLAGS_quic_reloadable_flag_quic_enable_3rtos.
Merge internal change: 154823650
https://codereview.chromium.org/2874033002/


Deprecate FLAGS_quic_reloadable_flag_quic_bbr_base_cwnd_on_srtt in disabled
state.
Merge internal change: 154780925
https://codereview.chromium.org/2870333002/


Add QUIC handshake accounting. Protected by
FLAGS_quic_reloadable_flag_quic_account_handshake.
Merge internal change: 154763851
https://codereview.chromium.org/2873883002/


Allow customization of client address used for stateless rejector to
generate and validate source address token. Protected by
FLAGS_quic_reloadable_flag_quic_use_client_address_for_stk_in_proxy.
Merge internal change: 154755746
https://codereview.chromium.org/2876443002/


R=rch@chromium.org
BUG=
==========

to

==========
Landing Recent QUIC changes until Mon May 8 21:42:46 2017 +0000

Add QUIC v40 which will be used to include changes:
1) Initial packet number is randomly chosen from [0:2^31]
2) WINDOW_UPDATE for connection flow control advertises value in 1024-byte units
3) Window updates split into MAX_DATA and MAX_STREAM_DATA
4) BLOCKED frame split into BLOCKED and STREAM_BLOCKED frames
Merge internal change: 155429780
https://codereview.chromium.org/2879533003/


Do not wrap a PCC sender with a PacingSender.
Right now, we cannot just blindly wrap a PCC-based sender with a
PacingSender.  Some SendAlgorithms can be wrapped by a pacer and some
cannot.  By default, do  not wrap a PCC sender with a pacer.
Merge internal change: 155393218
https://codereview.chromium.org/2881623002/


Deprecate FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming
Results in getting rid of all setting/getting of bidirectional_data member
variables, and a bunch of tests.
Merge internal change: 155389424
https://codereview.chromium.org/2872133008/


Migrate deprecated StringPiece::CopyToString to string::assign (or construction
of string, if appropriate)
Merge internal change: 155349312
https://codereview.chromium.org/2874913003/


Create scaffolding for experimenting with PCC.  Protected by
FLAGS_quic_reloadable_flag_quic_enable_pcc.
This code adds support for a new congestion-control algorithm, called
PCC, to be used by QUIC.
Merge internal change: 155088982
https://codereview.chromium.org/2874243004/


Revert two changes written by non-Googler authors.
Merge internal change: 155026903
https://codereview.chromium.org/2869273009/


Add relevant tags for PCC Congestion control
These will be used in the future to identify the PCC experiment and
the PCC congestion-control algorithm within the code.
Merge internal change: 154967674
https://codereview.chromium.org/2882503002/


Close the connection after 3RTOs if there are no open streams and the 3RTO
connection option is supplied.  Protected by
FLAGS_quic_reloadable_flag_quic_enable_3rtos.
Merge internal change: 154823650
https://codereview.chromium.org/2874033002/


Deprecate FLAGS_quic_reloadable_flag_quic_bbr_base_cwnd_on_srtt in disabled
state.
Merge internal change: 154780925
https://codereview.chromium.org/2870333002/


Add QUIC handshake accounting. Protected by
FLAGS_quic_reloadable_flag_quic_account_handshake.
Merge internal change: 154763851
https://codereview.chromium.org/2873883002/


Allow customization of client address used for stateless rejector to
generate and validate source address token. Protected by
FLAGS_quic_reloadable_flag_quic_use_client_address_for_stk_in_proxy.
Merge internal change: 154755746
https://codereview.chromium.org/2876443002/


R=rch@chromium.org
BUG=
==========

[mpw, 2017-05-12 18:58:49]

mpw@chromium.org changed reviewers:
+ csharrison@chromium.org, juliatuttle@chromium.org

[mpw, 2017-05-12 19:00:20]

On 2017/05/12 18:50:19, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Presubmit currently failing due to:

Missing LGTM from an OWNER for these files:
   
chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc
    components/domain_reliability/util.cc

Adding juliatuttle@chromium.org and csharrison@chromium.org for OWNERS approval
on those files.

[Charlie Harrison, 2017-05-12 19:06:07]

plm lgtm

[Julia Tuttle, 2017-05-12 19:10:41]

domain_reliability lgtm

[mpw, 2017-05-12 19:13:50]

On 2017/05/12 19:10:41, Julia Tuttle wrote:
> domain_reliability lgtm

Thanks, juliatuttle and csharrison, for the quick reviews!

[mpw, 2017-05-12 19:33:24]

The CQ bit was checked by mpw@chromium.org

[commit-bot: I haz the power, 2017-05-12 19:34:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 21:35:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494617604140510, "parent_rev":
"08aa82af5442daf861618f9f3511a0c6e20ae76a", "commit_rev":
"42a0166c209d0fbc20e0adb4bf352571804e0a07"}

[commit-bot: I haz the power, 2017-05-12 21:35:56]

Description was changed from

==========
Landing Recent QUIC changes until Mon May 8 21:42:46 2017 +0000

Add QUIC v40 which will be used to include changes:
1) Initial packet number is randomly chosen from [0:2^31]
2) WINDOW_UPDATE for connection flow control advertises value in 1024-byte units
3) Window updates split into MAX_DATA and MAX_STREAM_DATA
4) BLOCKED frame split into BLOCKED and STREAM_BLOCKED frames
Merge internal change: 155429780
https://codereview.chromium.org/2879533003/


Do not wrap a PCC sender with a PacingSender.
Right now, we cannot just blindly wrap a PCC-based sender with a
PacingSender.  Some SendAlgorithms can be wrapped by a pacer and some
cannot.  By default, do  not wrap a PCC sender with a pacer.
Merge internal change: 155393218
https://codereview.chromium.org/2881623002/


Deprecate FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming
Results in getting rid of all setting/getting of bidirectional_data member
variables, and a bunch of tests.
Merge internal change: 155389424
https://codereview.chromium.org/2872133008/


Migrate deprecated StringPiece::CopyToString to string::assign (or construction
of string, if appropriate)
Merge internal change: 155349312
https://codereview.chromium.org/2874913003/


Create scaffolding for experimenting with PCC.  Protected by
FLAGS_quic_reloadable_flag_quic_enable_pcc.
This code adds support for a new congestion-control algorithm, called
PCC, to be used by QUIC.
Merge internal change: 155088982
https://codereview.chromium.org/2874243004/


Revert two changes written by non-Googler authors.
Merge internal change: 155026903
https://codereview.chromium.org/2869273009/


Add relevant tags for PCC Congestion control
These will be used in the future to identify the PCC experiment and
the PCC congestion-control algorithm within the code.
Merge internal change: 154967674
https://codereview.chromium.org/2882503002/


Close the connection after 3RTOs if there are no open streams and the 3RTO
connection option is supplied.  Protected by
FLAGS_quic_reloadable_flag_quic_enable_3rtos.
Merge internal change: 154823650
https://codereview.chromium.org/2874033002/


Deprecate FLAGS_quic_reloadable_flag_quic_bbr_base_cwnd_on_srtt in disabled
state.
Merge internal change: 154780925
https://codereview.chromium.org/2870333002/


Add QUIC handshake accounting. Protected by
FLAGS_quic_reloadable_flag_quic_account_handshake.
Merge internal change: 154763851
https://codereview.chromium.org/2873883002/


Allow customization of client address used for stateless rejector to
generate and validate source address token. Protected by
FLAGS_quic_reloadable_flag_quic_use_client_address_for_stk_in_proxy.
Merge internal change: 154755746
https://codereview.chromium.org/2876443002/


R=rch@chromium.org
BUG=
==========

to

==========
Landing Recent QUIC changes until Mon May 8 21:42:46 2017 +0000

Add QUIC v40 which will be used to include changes:
1) Initial packet number is randomly chosen from [0:2^31]
2) WINDOW_UPDATE for connection flow control advertises value in 1024-byte units
3) Window updates split into MAX_DATA and MAX_STREAM_DATA
4) BLOCKED frame split into BLOCKED and STREAM_BLOCKED frames
Merge internal change: 155429780
https://codereview.chromium.org/2879533003/


Do not wrap a PCC sender with a PacingSender.
Right now, we cannot just blindly wrap a PCC-based sender with a
PacingSender.  Some SendAlgorithms can be wrapped by a pacer and some
cannot.  By default, do  not wrap a PCC sender with a pacer.
Merge internal change: 155393218
https://codereview.chromium.org/2881623002/


Deprecate FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming
Results in getting rid of all setting/getting of bidirectional_data member
variables, and a bunch of tests.
Merge internal change: 155389424
https://codereview.chromium.org/2872133008/


Migrate deprecated StringPiece::CopyToString to string::assign (or construction
of string, if appropriate)
Merge internal change: 155349312
https://codereview.chromium.org/2874913003/


Create scaffolding for experimenting with PCC.  Protected by
FLAGS_quic_reloadable_flag_quic_enable_pcc.
This code adds support for a new congestion-control algorithm, called
PCC, to be used by QUIC.
Merge internal change: 155088982
https://codereview.chromium.org/2874243004/


Revert two changes written by non-Googler authors.
Merge internal change: 155026903
https://codereview.chromium.org/2869273009/


Add relevant tags for PCC Congestion control
These will be used in the future to identify the PCC experiment and
the PCC congestion-control algorithm within the code.
Merge internal change: 154967674
https://codereview.chromium.org/2882503002/


Close the connection after 3RTOs if there are no open streams and the 3RTO
connection option is supplied.  Protected by
FLAGS_quic_reloadable_flag_quic_enable_3rtos.
Merge internal change: 154823650
https://codereview.chromium.org/2874033002/


Deprecate FLAGS_quic_reloadable_flag_quic_bbr_base_cwnd_on_srtt in disabled
state.
Merge internal change: 154780925
https://codereview.chromium.org/2870333002/


Add QUIC handshake accounting. Protected by
FLAGS_quic_reloadable_flag_quic_account_handshake.
Merge internal change: 154763851
https://codereview.chromium.org/2873883002/


Allow customization of client address used for stateless rejector to
generate and validate source address token. Protected by
FLAGS_quic_reloadable_flag_quic_use_client_address_for_stk_in_proxy.
Merge internal change: 154755746
https://codereview.chromium.org/2876443002/


R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2875333002
Cr-Commit-Position: refs/heads/master@{#471448}
Committed:
https://chromium.googlesource.com/chromium/src/+/42a0166c209d0fbc20e0adb4bf35...
==========

[commit-bot: I haz the power, 2017-05-12 21:35:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/42a0166c209d0fbc20e0adb4bf35...